You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Garrett Rooney <ro...@electricjellyfish.net> on 2005/03/17 17:50:51 UTC
Re: svn commit: r13458 - branches/locking/subversion/mod_dav_svn
cmpilato@tigris.org wrote:
> Author: cmpilato
> Date: Thu Mar 17 11:39:31 2005
> New Revision: 13458
>
> Modified:
> branches/locking/subversion/mod_dav_svn/dav_svn.h
> branches/locking/subversion/mod_dav_svn/repos.c
> Log:
> Locking branch: check the User-Agent header to determine if our
> accessor claims to be a Subversion client.
>
> * subversion/mod_dav_svn/dav_svn.h
> (dav_svn_repos): Add 'is_svn_client' member.
>
> * subversion/mod_dav_svn/repos.c
> (dav_svn_get_resource): Populate new repos->is_svn_client member.
>
Refresh my memory. Why are we going down this road? The idea of
special casing based on the User-Agent just seems oh so wrong to me...
-garrett
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r13458 - branches/locking/subversion/mod_dav_svn
Posted by "C. Michael Pilato" <cm...@collab.net>.
Garrett Rooney <ro...@electricjellyfish.net> writes:
> cmpilato@tigris.org wrote:
> > Author: cmpilato
> > Date: Thu Mar 17 11:39:31 2005
> > New Revision: 13458
> > Modified:
> > branches/locking/subversion/mod_dav_svn/dav_svn.h
> > branches/locking/subversion/mod_dav_svn/repos.c
> > Log:
> > Locking branch: check the User-Agent header to determine if our
> > accessor claims to be a Subversion client.
> > * subversion/mod_dav_svn/dav_svn.h
> > (dav_svn_repos): Add 'is_svn_client' member.
> > * subversion/mod_dav_svn/repos.c
> > (dav_svn_get_resource): Populate new repos->is_svn_client member.
> >
>
> Refresh my memory. Why are we going down this road? The idea of
> special casing based on the User-Agent just seems oh so wrong to
> me...
I thought this, too. But we already have tons of special-casing based
on custom headers supplied by Subversion clients, all aimed at making
the Subversion client experience better without hurting the generic
DAV clients. So, I started down the road of adding another custom
Subversion client header when it occurred to me that:
- doing so would not help my server deal with older Subversion
clients, and
- I'm only using this where it really wouldn't be the end of the
world if a non-Subversion client just happened to look like one
by its User-Agent droppings.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org