You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "pzygielo (via GitHub)" <gi...@apache.org> on 2023/01/29 08:41:58 UTC

[GitHub] [maven-compiler-plugin] pzygielo commented on a diff in pull request #172: [MCOMPILER-525] - Incremental recompile incorrect detection of dependency change

pzygielo commented on code in PR #172:
URL: https://github.com/apache/maven-compiler-plugin/pull/172#discussion_r1089900853


##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -902,7 +906,7 @@ else if ( CompilerConfiguration.CompilerReuseStrategy.ReuseSame.getStrategy().eq
                 {
                     String cause = idk ? "idk" : ( dependencyChanged ? "dependency"
                             : ( sourceChanged ? "source" : "input tree" ) );
-                    getLog().info( "Changes detected - recompiling the module! :" + cause );
+                    getLog().info( "Changes detected! - recompiling the module due to: " + cause );

Review Comment:
   If this message is going to change - could we drop exclamation point completely?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org