You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by an...@apache.org on 2016/12/06 09:12:33 UTC
hbase git commit: HBASE-17207 Arrays.asList() with too few arguments.
(John Leach)
Repository: hbase
Updated Branches:
refs/heads/master c7b8b63cd -> f11242742
HBASE-17207 Arrays.asList() with too few arguments. (John Leach)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/f1124274
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/f1124274
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/f1124274
Branch: refs/heads/master
Commit: f112427425b3ddaff40f1d2dc8a94e52d55213e8
Parents: c7b8b63
Author: anoopsamjohn <an...@gmail.com>
Authored: Tue Dec 6 14:42:14 2016 +0530
Committer: anoopsamjohn <an...@gmail.com>
Committed: Tue Dec 6 14:42:14 2016 +0530
----------------------------------------------------------------------
.../java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java | 4 ++--
.../main/java/org/apache/hadoop/hbase/client/MultiAction.java | 4 ++--
.../src/main/java/org/apache/hadoop/hbase/filter/FilterList.java | 3 ++-
.../hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java | 3 ++-
.../main/java/org/apache/hadoop/hbase/master/RackManager.java | 3 ++-
.../java/org/apache/hadoop/hbase/master/RegionStateStore.java | 3 ++-
6 files changed, 12 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/f1124274/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java
index f7eb09d..54955a0 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/BufferedMutatorImpl.java
@@ -27,7 +27,7 @@ import org.apache.hadoop.hbase.ipc.RpcControllerFactory;
import java.io.IOException;
import java.io.InterruptedIOException;
-import java.util.Arrays;
+import java.util.Collections;
import java.util.Iterator;
import java.util.List;
import java.util.NoSuchElementException;
@@ -129,7 +129,7 @@ public class BufferedMutatorImpl implements BufferedMutator {
@Override
public void mutate(Mutation m) throws InterruptedIOException,
RetriesExhaustedWithDetailsException {
- mutate(Arrays.asList(m));
+ mutate(Collections.singletonList(m));
}
@Override
http://git-wip-us.apache.org/repos/asf/hbase/blob/f1124274/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
index ef1fce9..dc4ec62 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiAction.java
@@ -19,7 +19,7 @@
package org.apache.hadoop.hbase.client;
import java.util.ArrayList;
-import java.util.Arrays;
+import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -68,7 +68,7 @@ public final class MultiAction {
* @param a
*/
public void add(byte[] regionName, Action a) {
- add(regionName, Arrays.asList(a));
+ add(regionName, Collections.singletonList(a));
}
/**
http://git-wip-us.apache.org/repos/asf/hbase/blob/f1124274/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java
index 746df3b..c10d18c 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FilterList.java
@@ -21,6 +21,7 @@ package org.apache.hadoop.hbase.filter;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Arrays;
+import java.util.Collections;
import java.util.List;
import org.apache.hadoop.hbase.Cell;
@@ -194,7 +195,7 @@ final public class FilterList extends FilterBase {
* @param filter another filter
*/
public void addFilter(Filter filter) {
- addFilter(Arrays.asList(filter));
+ addFilter(Collections.singletonList(filter));
}
@Override
http://git-wip-us.apache.org/repos/asf/hbase/blob/f1124274/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java
index c0121d8..9bf8695 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutputSaslHelper.java
@@ -54,6 +54,7 @@ import java.net.InetSocketAddress;
import java.nio.ByteBuffer;
import java.security.GeneralSecurityException;
import java.util.Arrays;
+import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -355,7 +356,7 @@ public final class FanOutOneBlockAsyncDFSOutputSaslHelper {
throw new IOException(String.format("Invalid cipher suite, %s=%s",
DFS_ENCRYPT_DATA_TRANSFER_CIPHER_SUITES_KEY, cipherSuites));
}
- return Arrays.asList(new CipherOption(CipherSuite.AES_CTR_NOPADDING));
+ return Collections.singletonList(new CipherOption(CipherSuite.AES_CTR_NOPADDING));
}
private void sendSaslMessage(ChannelHandlerContext ctx, byte[] payload,
http://git-wip-us.apache.org/repos/asf/hbase/blob/f1124274/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RackManager.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RackManager.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RackManager.java
index ea4612a..2b1fb50 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RackManager.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RackManager.java
@@ -19,6 +19,7 @@ package org.apache.hadoop.hbase.master;
import java.util.ArrayList;
import java.util.Arrays;
+import java.util.Collections;
import java.util.List;
import org.apache.commons.logging.Log;
@@ -63,7 +64,7 @@ public class RackManager {
}
// just a note - switchMapping caches results (at least the implementation should unless the
// resolution is really a lightweight process)
- List<String> racks = switchMapping.resolve(Arrays.asList(server.getHostname()));
+ List<String> racks = switchMapping.resolve(Collections.singletonList(server.getHostname()));
if (racks != null && !racks.isEmpty()) {
return racks.get(0);
}
http://git-wip-us.apache.org/repos/asf/hbase/blob/f1124274/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java
index 2dbc087..3a2a6d7 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java
@@ -21,6 +21,7 @@ import com.google.common.base.Preconditions;
import java.io.IOException;
import java.util.Arrays;
+import java.util.Collections;
import java.util.List;
import org.apache.commons.logging.Log;
@@ -243,7 +244,7 @@ public class RegionStateStore {
// Called when meta is not on master
List<Put> list = shouldPutBarrier ?
Arrays.asList(metaPut, MetaTableAccessor.makeBarrierPut(hri.getEncodedNameAsBytes(),
- openSeqNum, hri.getTable().getName())) : Arrays.asList(metaPut);
+ openSeqNum, hri.getTable().getName())) : Collections.singletonList(metaPut);
multiHConnection.processBatchCallback(list, TableName.META_TABLE_NAME, null, null);
} catch (IOException ioe) {