You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/28 01:51:30 UTC
[GitHub] [cloudstack-primate] utchoang opened a new pull request #631: FIX - Keep form/modal when clicking outside the form
utchoang opened a new pull request #631:
URL: https://github.com/apache/cloudstack-primate/pull/631
Open for https://github.com/apache/cloudstack-primate/issues/629
@rhtyd cc @svenvogel I've completed fix this task. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #631: FIX - Keep form/modal when clicking outside the form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #631:
URL: https://github.com/apache/cloudstack-primate/pull/631#issuecomment-682409003
@utchoang tip - when you send a PR that fixes an issue can you use `Fixes #id-of-pr` in the git commit or PR summary that way merging the PR will close the bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #631: FIX - Keep form/modal when clicking outside the form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #631:
URL: https://github.com/apache/cloudstack-primate/pull/631#issuecomment-682408632
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #631: FIX - Keep form/modal when clicking outside the form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #631:
URL: https://github.com/apache/cloudstack-primate/pull/631#issuecomment-682333756
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #631: FIX - Keep form/modal when clicking outside the form
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #631:
URL: https://github.com/apache/cloudstack-primate/pull/631#issuecomment-682333458
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #631: FIX - Keep form/modal when clicking outside the form
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #631:
URL: https://github.com/apache/cloudstack-primate/pull/631#discussion_r478959264
##########
File path: src/views/project/iam/ProjectRoleTab.vue
##########
@@ -103,7 +108,12 @@
</span>
</a-form>
</a-modal>
- <a-modal title="Create Project Role" v-model="createModalVisible" :footer="null" :afterClose="closeAction">
+ <a-modal
+ title="Create Project Role"
Review comment:
@Pearl1594 I think these are your feature - can you send another PR that fixes the translation keys?
##########
File path: src/views/project/iam/ProjectRoleTab.vue
##########
@@ -61,7 +61,12 @@
</a-tooltip>
</span>
</a-table>
- <a-modal title="Edit Project Role" v-model="editModalVisible" :footer="null" :afterClose="closeAction">
+ <a-modal
+ title="Edit Project Role"
Review comment:
@Pearl1594 I think these are your feature - can you send another PR that fixes the translation keys?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #631: FIX - Keep form/modal when clicking outside the form
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #631:
URL: https://github.com/apache/cloudstack-primate/pull/631#issuecomment-682336130
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/631 (JID-3384)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #631: FIX - Keep form/modal when clicking outside the form
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #631:
URL: https://github.com/apache/cloudstack-primate/pull/631
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org