[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8597: samv7: add support for complementary PWM output

["xiaoxiang781216 (via GitHub)" <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #8597:
URL: https://github.com/apache/nuttx/pull/8597#discussion_r1112167261


##########
arch/arm/src/samv7/sam_pwm.c:
##########
@@ -114,25 +115,45 @@ static struct sam_pwm_channel_s g_pwm0_channels[] =
 #ifdef CONFIG_SAMV7_PWM0_CH0
   {
     .channel = 0,
-    .pin     = GPIO_PWMC0_H0,
+    .pin_h     = GPIO_PWMC0_H0,

Review Comment:
   let's keep = align with line 117



##########
arch/arm/src/samv7/sam_pwm.c:
##########
@@ -114,25 +115,45 @@ static struct sam_pwm_channel_s g_pwm0_channels[] =
 #ifdef CONFIG_SAMV7_PWM0_CH0
   {
     .channel = 0,
-    .pin     = GPIO_PWMC0_H0,
+    .pin_h     = GPIO_PWMC0_H0,
+#ifdef CONFIG_SAMV7_PWM0_CH0_COMP
+    .pin_l     = GPIO_PWMC0_L0,
+#else
+    .pin_l     = 0,
+#endif
   },
 #endif
 #ifdef CONFIG_SAMV7_PWM0_CH1
   {
     .channel = 1,
-    .pin     = GPIO_PWMC0_H1,
+    .pin_h     = GPIO_PWMC0_H1,

Review Comment:
   ditto



##########
arch/arm/src/samv7/sam_pwm.c:
##########
@@ -185,7 +226,6 @@ static struct sam_pwm_s g_pwm1 =
 };
 
 #endif
-

Review Comment:
   revert the change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org