You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/04/13 15:40:58 UTC
Review Request 46143: Themes: Config placement is not respected in
theme inheritance scenario
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46143/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.
Bugs: AMBARI-15860
https://issues.apache.org/jira/browse/AMBARI-15860
Repository: ambari
Description
-------
STR:
Install ambari trunk bits
Replace theme_version_2.json in HDP-2.5 HIVE service package with theme_version_2.json
Deploy a cluster with Hive service HDP-2.5 stack with ambari trunk bits
Expected behavior: Interactive Query subsection in Hive service page has the configs placed as defined in extended theme of HIVE service in HDP-2.5 stack
Actual behavior: API and UI has configs in different order then what is defined in the theme.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/theme/Placement.java e3708d8
ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java a0d8907
Diff: https://reviews.apache.org/r/46143/diff/
Testing
-------
mvn clean test
Thanks,
Vitalyi Brodetskyi
Re: Review Request 46143: Themes: Config placement is not respected
in theme inheritance scenario
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46143/#review128664
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Апрель 13, 2016, 1:40 п.п., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46143/
> -----------------------------------------------------------
>
> (Updated Апрель 13, 2016, 1:40 п.п.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.
>
>
> Bugs: AMBARI-15860
> https://issues.apache.org/jira/browse/AMBARI-15860
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> Install ambari trunk bits
> Replace theme_version_2.json in HDP-2.5 HIVE service package with theme_version_2.json
> Deploy a cluster with Hive service HDP-2.5 stack with ambari trunk bits
> Expected behavior: Interactive Query subsection in Hive service page has the configs placed as defined in extended theme of HIVE service in HDP-2.5 stack
> Actual behavior: API and UI has configs in different order then what is defined in the theme.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Placement.java e3708d8
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java a0d8907
>
> Diff: https://reviews.apache.org/r/46143/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 46143: Themes: Config placement is not respected
in theme inheritance scenario
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46143/#review128663
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On April 13, 2016, 1:40 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46143/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 1:40 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Dmytro Sen.
>
>
> Bugs: AMBARI-15860
> https://issues.apache.org/jira/browse/AMBARI-15860
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR:
> Install ambari trunk bits
> Replace theme_version_2.json in HDP-2.5 HIVE service package with theme_version_2.json
> Deploy a cluster with Hive service HDP-2.5 stack with ambari trunk bits
> Expected behavior: Interactive Query subsection in Hive service page has the configs placed as defined in extended theme of HIVE service in HDP-2.5 stack
> Actual behavior: API and UI has configs in different order then what is defined in the theme.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/Placement.java e3708d8
> ambari-server/src/main/java/org/apache/ambari/server/state/theme/ThemeConfiguration.java a0d8907
>
> Diff: https://reviews.apache.org/r/46143/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>