You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2024/01/17 09:18:11 UTC

[I] [Improvement] Improve the error log message for checkBlockSendResult [incubator-uniffle]

rickyma opened a new issue, #1464:
URL: https://github.com/apache/incubator-uniffle/issues/1464

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the [issues](https://github.com/apache/incubator-uniffle/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What would you like to be improved?
   
   Currently, when method `checkBlockSendResult` will only print error log like below:
   org.apache.uniffle.common.exception.RssSendFailedException: Send failed: Task[7173_0] failed because 72 blocks can't be sent to shuffle server.
   This is not enough. I think a more detailed version would be something like below:
   org.apache.uniffle.common.exception.RssSendFailedException: Send failed: Task[7173_0] failed because 72 blocks can't be sent to shuffle server: [ShuffleServerInfo{id[127.0.0.1-19977-17000], host[127.0.0.1], grpc port[19977], netty port[17000]}].
   
   Also, I think we don't need `id` in ShuffleServerInfo.toString, which I think is useless.
   
   So the final output would be:
   org.apache.uniffle.common.exception.RssSendFailedException: Send failed: Task[7173_0] failed because 72 blocks can't be sent to shuffle server: [ShuffleServerInfo{host[127.0.0.1], grpc port[19977], netty port[17000]}].
   
   This is useful when troubleshooting.
   
   ### How should we improve?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [I] [Improvement] Improve the error log message for checkBlockSendResult [incubator-uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston closed issue #1464: [Improvement] Improve the error log message for checkBlockSendResult
URL: https://github.com/apache/incubator-uniffle/issues/1464


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org