You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Sai Pullabhotla (JIRA)" <ji...@apache.org> on 2010/03/26 12:52:27 UTC
[jira] Created: (FTPSERVER-360) When no passive ports are available
error out immediately rather than waiting for a port to become available
When no passive ports are available error out immediately rather than waiting for a port to become available
------------------------------------------------------------------------------------------------------------
Key: FTPSERVER-360
URL: https://issues.apache.org/jira/browse/FTPSERVER-360
Project: FtpServer
Issue Type: Bug
Affects Versions: 1.0.4
Reporter: Sai Pullabhotla
Fix For: 1.0.5
Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FTPSERVER-360) When no passive ports are available
error out immediately rather than waiting for a port to become available
Posted by "Sai Pullabhotla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sai Pullabhotla updated FTPSERVER-360:
--------------------------------------
Attachment: FTPSERVER-360.patch
Here is a patch to try out to see if the server locks up as reported in the issue 359. This patch error out immediately when no passive ports are available. This is mainly for testing with the test case provided the submitter of FTPSERVER-359. Not sure if it is ready to be included in the code base.
> When no passive ports are available error out immediately rather than waiting for a port to become available
> ------------------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-360
> URL: https://issues.apache.org/jira/browse/FTPSERVER-360
> Project: FtpServer
> Issue Type: Bug
> Affects Versions: 1.0.4
> Reporter: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-360.patch
>
>
> Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-360) When no passive ports are
available error out immediately rather than waiting for a port to become
available
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850729#action_12850729 ]
Niklas Gustavsson commented on FTPSERVER-360:
---------------------------------------------
Yeah, that's right.
> When no passive ports are available error out immediately rather than waiting for a port to become available
> ------------------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-360
> URL: https://issues.apache.org/jira/browse/FTPSERVER-360
> Project: FtpServer
> Issue Type: Bug
> Affects Versions: 1.0.4
> Reporter: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-360.patch
>
>
> Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-360) When no passive ports are
available error out immediately rather than waiting for a port to become
available
Posted by "Sai Pullabhotla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850734#action_12850734 ]
Sai Pullabhotla commented on FTPSERVER-360:
-------------------------------------------
Okay, I think I got a test case for this. What all branches do you want this fix to go in, in addition to the trunk?
A side note - I do see two branches - 1.0.4 and 1.0.x. However, I do not see a 1.0.4 tag. Did we create a branch for 1.0.4 where it should have been a tag?
> When no passive ports are available error out immediately rather than waiting for a port to become available
> ------------------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-360
> URL: https://issues.apache.org/jira/browse/FTPSERVER-360
> Project: FtpServer
> Issue Type: Bug
> Affects Versions: 1.0.4
> Reporter: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-360.patch
>
>
> Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FTPSERVER-360) When no passive ports are available
error out immediately rather than waiting for a port to become available
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson updated FTPSERVER-360:
----------------------------------------
Fix Version/s: 1.1.0
> When no passive ports are available error out immediately rather than waiting for a port to become available
> ------------------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-360
> URL: https://issues.apache.org/jira/browse/FTPSERVER-360
> Project: FtpServer
> Issue Type: Bug
> Affects Versions: 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.0.6, 1.1.0
>
> Attachments: FTPSERVER-360.patch
>
>
> Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-360) When no passive ports are
available error out immediately rather than waiting for a port to become
available
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850737#action_12850737 ]
Niklas Gustavsson commented on FTPSERVER-360:
---------------------------------------------
I think this should go in trunk and 1.0.x (to fix the bug reported in 1.0.x).
I've fixed the forgotten move from branches to tags. My bad.
> When no passive ports are available error out immediately rather than waiting for a port to become available
> ------------------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-360
> URL: https://issues.apache.org/jira/browse/FTPSERVER-360
> Project: FtpServer
> Issue Type: Bug
> Affects Versions: 1.0.4
> Reporter: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-360.patch
>
>
> Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FTPSERVER-360) When no passive ports are
available error out immediately rather than waiting for a port to become
available
Posted by "Sai Pullabhotla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sai Pullabhotla reassigned FTPSERVER-360:
-----------------------------------------
Assignee: Sai Pullabhotla
> When no passive ports are available error out immediately rather than waiting for a port to become available
> ------------------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-360
> URL: https://issues.apache.org/jira/browse/FTPSERVER-360
> Project: FtpServer
> Issue Type: Bug
> Affects Versions: 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-360.patch
>
>
> Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-360) When no passive ports are
available error out immediately rather than waiting for a port to become
available
Posted by "Sai Pullabhotla (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850728#action_12850728 ]
Sai Pullabhotla commented on FTPSERVER-360:
-------------------------------------------
Niklas,
Are you looking for a "client" test case, to actually connect to the server and try opening passive connections? Otherwise, the current test cases are good enough.
> When no passive ports are available error out immediately rather than waiting for a port to become available
> ------------------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-360
> URL: https://issues.apache.org/jira/browse/FTPSERVER-360
> Project: FtpServer
> Issue Type: Bug
> Affects Versions: 1.0.4
> Reporter: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-360.patch
>
>
> Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FTPSERVER-360) When no passive ports are
available error out immediately rather than waiting for a port to become
available
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850120#action_12850120 ]
Niklas Gustavsson commented on FTPSERVER-360:
---------------------------------------------
Patche seems good, we also need a test case to show that we now return an error if the passive ports are used.
> When no passive ports are available error out immediately rather than waiting for a port to become available
> ------------------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-360
> URL: https://issues.apache.org/jira/browse/FTPSERVER-360
> Project: FtpServer
> Issue Type: Bug
> Affects Versions: 1.0.4
> Reporter: Sai Pullabhotla
> Fix For: 1.0.5
>
> Attachments: FTPSERVER-360.patch
>
>
> Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FTPSERVER-360) When no passive ports are available
error out immediately rather than waiting for a port to become available
Posted by "Niklas Gustavsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FTPSERVER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Gustavsson updated FTPSERVER-360:
----------------------------------------
Fix Version/s: 1.0.6
(was: 1.0.5)
> When no passive ports are available error out immediately rather than waiting for a port to become available
> ------------------------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-360
> URL: https://issues.apache.org/jira/browse/FTPSERVER-360
> Project: FtpServer
> Issue Type: Bug
> Affects Versions: 1.0.4
> Reporter: Sai Pullabhotla
> Assignee: Sai Pullabhotla
> Fix For: 1.0.6
>
> Attachments: FTPSERVER-360.patch
>
>
> Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.