You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/05/20 21:32:12 UTC
[kudu-CR] [tools] a small cleanup on ksck code
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13379
Change subject: [tools] a small cleanup on ksck code
......................................................................
[tools] a small cleanup on ksck code
Change-Id: I14d2451cc757c95543be6fa8c7dc5c95c7d73be8
---
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
3 files changed, 101 insertions(+), 105 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/13379/1
--
To view, visit http://gerrit.cloudera.org:8080/13379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I14d2451cc757c95543be6fa8c7dc5c95c7d73be8
Gerrit-Change-Number: 13379
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tools] a small cleanup on ksck code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13379 )
Change subject: [tools] a small cleanup on ksck code
......................................................................
[tools] a small cleanup on ksck code
Change-Id: I14d2451cc757c95543be6fa8c7dc5c95c7d73be8
Reviewed-on: http://gerrit.cloudera.org:8080/13379
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote.cc
3 files changed, 101 insertions(+), 105 deletions(-)
Approvals:
Alexey Serbin: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I14d2451cc757c95543be6fa8c7dc5c95c7d73be8
Gerrit-Change-Number: 13379
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [tools] a small cleanup on ksck code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13379 )
Change subject: [tools] a small cleanup on ksck code
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I14d2451cc757c95543be6fa8c7dc5c95c7d73be8
Gerrit-Change-Number: 13379
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tools] a small cleanup on ksck code
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13379 )
Change subject: [tools] a small cleanup on ksck code
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14d2451cc757c95543be6fa8c7dc5c95c7d73be8
Gerrit-Change-Number: 13379
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 21 May 2019 20:04:53 +0000
Gerrit-HasComments: No
[kudu-CR] [tools] a small cleanup on ksck code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13379 )
Change subject: [tools] a small cleanup on ksck code
......................................................................
Patch Set 1: Verified+1
unrelated failures in the following tests:
* org.apache.kudu.client.TestSecurity
* org.apache.kudu.backup.TestKuduBackup
* WriteThrottlingTest.ThrottleWriteRpcPerSec
--
To view, visit http://gerrit.cloudera.org:8080/13379
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I14d2451cc757c95543be6fa8c7dc5c95c7d73be8
Gerrit-Change-Number: 13379
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 20 May 2019 22:36:09 +0000
Gerrit-HasComments: No