You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@spamassassin.apache.org by Henrik K <he...@hege.li> on 2019/04/04 04:16:53 UTC

Re: svn commit: r1856885 - in /spamassassin: branches/3.4/lib/Mail/SpamAssassin/Plugin/DNSEval.pm trunk/lib/Mail/SpamAssassin/Plugin/DNSEval.pm

On Wed, Apr 03, 2019 at 05:12:10PM -0000, gbechis@apache.org wrote:

> +  my @ns = $pms->lookup_ns($host);

Should not be used, it's legacy non-async function.  This needs to be
changed to async callback, similar code can be found from URIDNSBL.

> +  my @rd_ns = $ns[0];

Also this is missing any lookup error checking..

Re: svn commit: r1856885 - in /spamassassin: branches/3.4/lib/Mail/SpamAssassin/Plugin/DNSEval.pm trunk/lib/Mail/SpamAssassin/Plugin/DNSEval.pm

Posted by Giovanni Bechis <gb...@apache.org>.

On 4/4/19 6:16 AM, Henrik K wrote:
> On Wed, Apr 03, 2019 at 05:12:10PM -0000, gbechis@apache.org wrote:
> 
>> +  my @ns = $pms->lookup_ns($host);
> 
> Should not be used, it's legacy non-async function.  This needs to be
> changed to async callback, similar code can be found from URIDNSBL.
> 
>> +  my @rd_ns = $ns[0];
> 
> Also this is missing any lookup error checking..
> 
Thanks.
 Giovanni