[jira] Updated: (HARMONY-3934) [drlvm][init] DRLVM should report error message for incorrect parameters

["Vladimir Beliaev (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HARMONY-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vladimir Beliaev updated HARMONY-3934:
--------------------------------------

    Attachment: H3934.patch

Ok, based on dev-list discussion results (no objection) I'm renaming vm.dlls properties to gc.dll one.
(http://mail-archives.apache.org/mod_mbox/harmony-dev/200706.mbox/%3c587698b80706270633n7fb7e54m6c05cbb41f062107@mail.gmail.com%3e)

The attached patch does the following things:

1. reports error if -XX propery format is broken (-XX:+key, -XX:-key or -XX:key=[value] is allowed), i.e. '-XX:gc.dll=' is a proper specification (of empty value) while '-XX:gc.dll' argument produces error ('initialize_properties' returnns the status code now).

2. renamed 'vm.dlls' to 'gc.dll'". This required to do the following:

    2.1 add a check that "gc.dll" property is always set (the vm_init code expects this property is set either to default value or it is set through command line)

   2.2 remove "parsing cycle" of gc.dll (previously "vm.dlls" may contain the list of DLLs)

I've tested DRLVM with different variants of related command line - works as expected.

Please get the patch committed.

Thanks
Vladimir Beliaev


> [drlvm][init] DRLVM should report error message for incorrect parameters
> ------------------------------------------------------------------------
>
>                 Key: HARMONY-3934
>                 URL: https://issues.apache.org/jira/browse/HARMONY-3934
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Vladimir Ivanov
>         Attachments: H3934.patch, screenshot-1.jpg
>
>
> DRLVM should report error message for incorrect parameters instead of crash.
> For example, run of cunit tests as:
>     build.bat cunit.test -Dtest.vmargs=-XX:vm.dlls=gc_cc.dll
> leads to the debug window on WinXP (attached) while
>     build.bat cunit.test -Dtest.vmargs="-XX:vm.dlls=gc_cc.dll"
> works OK.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.