Re: [PR] Upgrade commons libs, asm, jgit, jna, jackson, felix, jacoco and junit [netbeans]

["mbien (via GitHub)" <gi...@apache.org>]

mbien commented on code in PR #7237:
URL: https://github.com/apache/netbeans/pull/7237#discussion_r1555127793


##########
php/php.editor/test/unit/src/org/netbeans/modules/php/editor/completion/PHPCCDocumentationTest.java:
##########
@@ -559,7 +559,7 @@ public void testDNFTypesPropertyTag() throws Exception {
     }
 
     public void testDNFTypesMethodTag() throws Exception {
-        checkCompletionDocumentation("testfiles/completion/documentation/php82/dnfTypes.php", "$this->methodT^ag($param1, $param2);", false, "");
+        checkCompletionDocumentation("testfiles/completion/documentation/php82/dnfTypes.php", "$this->methodTa^g($param1, $param2);", false, "");

Review Comment:
   the interesting aspect about this issue here was that the test support classes take the first completion item and simply go with it (in this case 'methodTag' and 'methodTest'). It seems like what is first can depend on the environment which can cause test failures. For some reason the lib upgrade here guaranteed test failure on windows.
   
   https://github.com/apache/netbeans/blob/cac7b2c80f680dd9f65104510a0c979d7e3f92c9/ide/csl.api/test/unit/src/org/netbeans/modules/csl/api/test/CslTestBase.java#L3148-L3154
   
   I think we should consider to fail the test right away when this loop returns more than one match since this would indicate that the test case is likely not stable and then update the tests. Or make sure that `proposals` has a stable order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists