You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/02 14:45:33 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #10161:
[FLINK-13986][runtime] Clean up legacy code for FLIP-49.
azagrebin commented on a change in pull request #10161: [FLINK-13986][runtime] Clean up legacy code for FLIP-49.
URL: https://github.com/apache/flink/pull/10161#discussion_r352626500
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorResourceUtils.java
##########
@@ -433,7 +433,15 @@ private static MemorySize getTotalFlinkMemorySize(final Configuration config) {
private static MemorySize getTotalProcessMemorySize(final Configuration config) {
checkArgument(isTotalProcessMemorySizeExplicitlyConfigured(config));
- if (config.contains(TaskManagerOptions.TOTAL_PROCESS_MEMORY)) {
+ String totalProcessEnv = System.getenv("FLINK_TM_HEAP");
Review comment:
unit test to cover this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services