You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/05/05 16:25:18 UTC
[GitHub] [camel-kafka-connector] orpiske opened a new issue #191: Use the deliverable artifact the in the plugin.path
orpiske opened a new issue #191:
URL: https://github.com/apache/camel-kafka-connector/issues/191
The plugin.path configured in the connect runtime uses either the path of the [packaged jar](https://github.com/apache/camel-kafka-connector/blob/2b46335a9d28bbf09ca37507d409b0db9322b616/tests/src/test/java/org/apache/camel/kafkaconnector/PluginPathHelper.java#L45) or the [compiled classes](https://github.com/apache/camel-kafka-connector/blob/2b46335a9d28bbf09ca37507d409b0db9322b616/tests/src/test/java/org/apache/camel/kafkaconnector/PluginPathHelper.java#L64).
There is one circumstance where this is less than ideal: when the jar file is used to determine the path, the compiled class files will *also* be present. Therefore, the behavior is not entirely deterministic and could lead to subtle bugs during test execution (in case there are circumstances modifying how the connect runtime determines what to load).
Some possible solutions:
- remove the compiled classes prior to the `verify` target
- copy the jar file to a different/temporary location and use that in the plugin path
- extract the package to a temporary location prior to the test, and use its location in the plugin path (also adjusting the test dependencies to `provided` scope).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on issue #191: Use the deliverable artifact the in the plugin.path
Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #191:
URL: https://github.com/apache/camel-kafka-connector/issues/191#issuecomment-624157377
c/c: @valdar
The risk we were discussing today.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar commented on issue #191: Use the deliverable artifact in the plugin.path during testing
Posted by GitBox <gi...@apache.org>.
valdar commented on issue #191:
URL: https://github.com/apache/camel-kafka-connector/issues/191#issuecomment-812515113
@orpiske where do we stand in your opinion about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] orpiske commented on issue #191: Use the deliverable artifact in the plugin.path during testing
Posted by GitBox <gi...@apache.org>.
orpiske commented on issue #191:
URL: https://github.com/apache/camel-kafka-connector/issues/191#issuecomment-813881175
So, I think the only way we could do something like this is by testing it outside of the build (as in a by a separate test framework). Although the risk do exist, we haven't come across it in since the project beginning. Therefore, I think we can close this as 'won't fix'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org