You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "junrushao (via GitHub)" <gi...@apache.org> on 2023/08/28 15:59:08 UTC

[GitHub] [tvm] junrushao commented on a diff in pull request #15634: [Disco] Support ShapeTuple in Disco Protocol

junrushao commented on code in PR #15634:
URL: https://github.com/apache/tvm/pull/15634#discussion_r1307612173


##########
src/runtime/disco/threaded_session.cc:
##########
@@ -146,13 +152,17 @@ class DiscoThreadedMessageQueue : public dmlc::Stream {
       this->Read<int64_t>(&dref->reg_id);
       dref->session = Session{nullptr};
       result = ObjectRef(std::move(dref));
+    } else if (type_index == TypeIndex::kRuntimeString) {
+      uint64_t size = 0;

Review Comment:
   I'm not sure if my understanding is correct here. In `WriteObj`, we write the string's actual length to dmlc::Stream, and in `ReadObj` here, we create an `std::string` of length `len + 1`, and update its first `len` characters. I suppose in either case, the terminal character is not included.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org