You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Balázs Bence Sári <bs...@hortonworks.com> on 2017/07/05 19:48:09 UTC
Review Request 60665: Add swagger annotations to the new
AmbariConfigurationService class.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60665/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, and Sebastian Toader.
Bugs: AMBARI-21307
https://issues.apache.org/jira/browse/AMBARI-21307
Repository: ambari
Description
-------
Added swagger annotations to the new AmbariConfigurationService class.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java 0fa6e44
Diff: https://reviews.apache.org/r/60665/diff/1/
Testing
-------
Manually checked the generated html.
Thanks,
Balázs Bence Sári
Re: Review Request 60665: Add swagger annotations to the new
AmbariConfigurationService class.
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60665/#review179760
-----------------------------------------------------------
Fix it, then Ship it!
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
Lines 29 (patched)
<https://reviews.apache.org/r/60665/#comment254594>
Shouldn't this return `AmbariConfigurationRequestInfo`?
- Attila Doroszlai
On July 5, 2017, 9:48 p.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60665/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 9:48 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, and Sebastian Toader.
>
>
> Bugs: AMBARI-21307
> https://issues.apache.org/jira/browse/AMBARI-21307
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added swagger annotations to the new AmbariConfigurationService class.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java 0fa6e44
>
>
> Diff: https://reviews.apache.org/r/60665/diff/1/
>
>
> Testing
> -------
>
> Manually checked the generated html.
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 60665: Add swagger annotations to the new
AmbariConfigurationService class.
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60665/#review179773
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On July 6, 2017, 10:13 a.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60665/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 10:13 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, and Sebastian Toader.
>
>
> Bugs: AMBARI-21307
> https://issues.apache.org/jira/browse/AMBARI-21307
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added swagger annotations to the new AmbariConfigurationService class.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java 0fa6e44
>
>
> Diff: https://reviews.apache.org/r/60665/diff/2/
>
>
> Testing
> -------
>
> Manually checked the generated html.
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 60665: Add swagger annotations to the new
AmbariConfigurationService class.
Posted by Laszlo Puskas <lp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60665/#review179771
-----------------------------------------------------------
Ship it!
Ship It!
- Laszlo Puskas
On July 6, 2017, 10:13 a.m., Balázs Bence Sári wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60665/
> -----------------------------------------------------------
>
> (Updated July 6, 2017, 10:13 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, and Sebastian Toader.
>
>
> Bugs: AMBARI-21307
> https://issues.apache.org/jira/browse/AMBARI-21307
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added swagger annotations to the new AmbariConfigurationService class.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java 0fa6e44
>
>
> Diff: https://reviews.apache.org/r/60665/diff/2/
>
>
> Testing
> -------
>
> Manually checked the generated html.
>
>
> Thanks,
>
> Balázs Bence Sári
>
>
Re: Review Request 60665: Add swagger annotations to the new
AmbariConfigurationService class.
Posted by Balázs Bence Sári <bs...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60665/
-----------------------------------------------------------
(Updated July 6, 2017, 10:13 a.m.)
Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo, and Sebastian Toader.
Changes
-------
Fix a review comment and few other things
Bugs: AMBARI-21307
https://issues.apache.org/jira/browse/AMBARI-21307
Repository: ambari
Description
-------
Added swagger annotations to the new AmbariConfigurationService class.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java 0fa6e44
Diff: https://reviews.apache.org/r/60665/diff/2/
Changes: https://reviews.apache.org/r/60665/diff/1-2/
Testing
-------
Manually checked the generated html.
Thanks,
Balázs Bence Sári