You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/14 15:32:19 UTC
[GitHub] [airflow] dstandish commented on a diff in pull request #27024: Update WasbHook to reflect preference for unprefixed extra
dstandish commented on code in PR #27024:
URL: https://github.com/apache/airflow/pull/27024#discussion_r995888509
##########
airflow/providers/microsoft/azure/hooks/wasb.py:
##########
@@ -119,6 +150,17 @@ def __init__(
except ValueError:
logger.setLevel(logging.WARNING)
+ def _get_field(self, extra_dict, field_name):
+ prefix = 'extra__wasb__'
+ if field_name.startswith('extra_'):
+ raise ValueError(
+ f"Got prefixed name {field_name}; please remove the '{prefix}' prefix "
+ f"when using this method."
+ )
+ if field_name in extra_dict:
+ return extra_dict[field_name] or None
+ return extra_dict.get(f"{prefix}{field_name}") or None
Review Comment:
difference is empty string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org