You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Zsombor Gegesy (JIRA)" <se...@james.apache.org> on 2006/10/20 09:19:34 UTC
[jira] Created: (JAMES-664) Improve fetch command parsing to
support Evolution
Improve fetch command parsing to support Evolution
---------------------------------------------------
Key: JAMES-664
URL: http://issues.apache.org/jira/browse/JAMES-664
Project: James
Issue Type: Improvement
Components: IMAPServer
Affects Versions: Trunk
Reporter: Zsombor Gegesy
Fix For: Trunk
Evolution use the following commands when fetching message, browsing mailboxes:
C00006 UID FETCH 1 BODY.PEEK[]
D00008 FETCH 1 UID
This is not supported in the current codebase, the attached patch fix this problem
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Assigned: (JAMES-664) Improve fetch command parsing to
support Evolution
Posted by "Joachim Draeger (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-664?page=all ]
Joachim Draeger reassigned JAMES-664:
-------------------------------------
Assignee: Joachim Draeger
> Improve fetch command parsing to support Evolution
> --------------------------------------------------
>
> Key: JAMES-664
> URL: http://issues.apache.org/jira/browse/JAMES-664
> Project: James
> Issue Type: Improvement
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Zsombor Gegesy
> Assigned To: Joachim Draeger
> Fix For: Trunk
>
> Attachments: fetch-fixes.patch
>
>
> Evolution use the following commands when fetching message, browsing mailboxes:
> C00006 UID FETCH 1 BODY.PEEK[]
> D00008 FETCH 1 UID
> This is not supported in the current codebase, the attached patch fix this problem
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-664) Improve fetch command parsing to
support Evolution
Posted by "Joachim Draeger (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-664?page=comments#action_12445715 ]
Joachim Draeger commented on JAMES-664:
---------------------------------------
Oh, I'm sorry. I didn't get any JIRA notifications about your updates!
I heard rumors that the notifications were broken.
I hope to have time to look at it soon!
> Improve fetch command parsing to support Evolution
> --------------------------------------------------
>
> Key: JAMES-664
> URL: http://issues.apache.org/jira/browse/JAMES-664
> Project: James
> Issue Type: Improvement
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Zsombor Gegesy
> Assigned To: Joachim Draeger
> Fix For: Trunk
>
> Attachments: fetch-fixes-2.patch, fetch-fixes.patch, fetch-test-fixes.patch
>
>
> Evolution use the following commands when fetching message, browsing mailboxes:
> C00006 UID FETCH 1 BODY.PEEK[]
> D00008 FETCH 1 UID
> This is not supported in the current codebase, the attached patch fix this problem
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-664) Improve fetch command parsing to
support Evolution
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-664?page=all ]
Stefano Bagnara updated JAMES-664:
----------------------------------
Fix Version/s: Next Major
(was: Trunk)
Before we'll branch everything we fix in trunk will be part of next-major: so next-major as fix version was ok.
> Improve fetch command parsing to support Evolution
> --------------------------------------------------
>
> Key: JAMES-664
> URL: http://issues.apache.org/jira/browse/JAMES-664
> Project: James
> Issue Type: Improvement
> Components: IMAPServer
> Affects Versions: Next Major
> Reporter: Zsombor Gegesy
> Assigned To: Joachim Draeger
> Fix For: Next Major
>
> Attachments: fetch-fixes-2.patch, fetch-fixes.patch, fetch-test-fixes.patch
>
>
> Evolution use the following commands when fetching message, browsing mailboxes:
> C00006 UID FETCH 1 BODY.PEEK[]
> D00008 FETCH 1 UID
> This is not supported in the current codebase, the attached patch fix this problem
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (JAMES-664) Improve fetch command parsing to
support Evolution
Posted by "Joachim Draeger (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-664?page=all ]
Joachim Draeger resolved JAMES-664.
-----------------------------------
Fix Version/s: Trunk
(was: Next Major)
Resolution: Fixed
applied the patch to trunk, the FetchCommand session test has been extended
> Improve fetch command parsing to support Evolution
> --------------------------------------------------
>
> Key: JAMES-664
> URL: http://issues.apache.org/jira/browse/JAMES-664
> Project: James
> Issue Type: Improvement
> Components: IMAPServer
> Affects Versions: Next Major
> Reporter: Zsombor Gegesy
> Assigned To: Joachim Draeger
> Fix For: Trunk
>
> Attachments: fetch-fixes-2.patch, fetch-fixes.patch, fetch-test-fixes.patch
>
>
> Evolution use the following commands when fetching message, browsing mailboxes:
> C00006 UID FETCH 1 BODY.PEEK[]
> D00008 FETCH 1 UID
> This is not supported in the current codebase, the attached patch fix this problem
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-664) Improve fetch command parsing to
support Evolution
Posted by "Joachim Draeger (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-664?page=comments#action_12443814 ]
Joachim Draeger commented on JAMES-664:
---------------------------------------
Thanks for reporting and the patch!
I can confirm this. Current implementation requires the "data items to be fetched" in a parenthesized list,
even if it's only one.
Like:
C00006 UID FETCH 1 (BODY.PEEK[])
D00008 FETCH 1 (UID)
RFC allows a "single atom", without parenthesis, as seen above.
ABNF from rfc3501 is clear here:
fetch = "FETCH" SP sequence-set SP ("ALL" / "FULL" / "FAST" /
fetch-att / "(" fetch-att *(SP fetch-att) ")")
I will likely apply the patch, after I've written some unit tests. The whole parsing of many commands has become quite complicated and that's why difficult to read and error prone. I hope we'll find a better way sometime.
> Improve fetch command parsing to support Evolution
> --------------------------------------------------
>
> Key: JAMES-664
> URL: http://issues.apache.org/jira/browse/JAMES-664
> Project: James
> Issue Type: Improvement
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Zsombor Gegesy
> Assigned To: Joachim Draeger
> Fix For: Trunk
>
> Attachments: fetch-fixes.patch
>
>
> Evolution use the following commands when fetching message, browsing mailboxes:
> C00006 UID FETCH 1 BODY.PEEK[]
> D00008 FETCH 1 UID
> This is not supported in the current codebase, the attached patch fix this problem
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (JAMES-664) Improve fetch command parsing to
support Evolution
Posted by "Zsombor Gegesy (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-664?page=all ]
Zsombor Gegesy updated JAMES-664:
---------------------------------
Attachment: fetch-fixes.patch
The patch for FetchCommand.java
> Improve fetch command parsing to support Evolution
> --------------------------------------------------
>
> Key: JAMES-664
> URL: http://issues.apache.org/jira/browse/JAMES-664
> Project: James
> Issue Type: Improvement
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Zsombor Gegesy
> Fix For: Trunk
>
> Attachments: fetch-fixes.patch
>
>
> Evolution use the following commands when fetching message, browsing mailboxes:
> C00006 UID FETCH 1 BODY.PEEK[]
> D00008 FETCH 1 UID
> This is not supported in the current codebase, the attached patch fix this problem
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (JAMES-664) Improve fetch command parsing to
support Evolution
Posted by "Zsombor Gegesy (JIRA)" <se...@james.apache.org>.
[ http://issues.apache.org/jira/browse/JAMES-664?page=comments#action_12445710 ]
Zsombor Gegesy commented on JAMES-664:
--------------------------------------
Have you found any new issue with the patch?
> Improve fetch command parsing to support Evolution
> --------------------------------------------------
>
> Key: JAMES-664
> URL: http://issues.apache.org/jira/browse/JAMES-664
> Project: James
> Issue Type: Improvement
> Components: IMAPServer
> Affects Versions: Trunk
> Reporter: Zsombor Gegesy
> Assigned To: Joachim Draeger
> Fix For: Trunk
>
> Attachments: fetch-fixes-2.patch, fetch-fixes.patch, fetch-test-fixes.patch
>
>
> Evolution use the following commands when fetching message, browsing mailboxes:
> C00006 UID FETCH 1 BODY.PEEK[]
> D00008 FETCH 1 UID
> This is not supported in the current codebase, the attached patch fix this problem
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org