You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/08/19 02:35:57 UTC
[GitHub] [kafka] mjsax opened a new pull request #11233: HOTIFX: Disable spurious left/outer stream-stream join fix
mjsax opened a new pull request #11233:
URL: https://github.com/apache/kafka/pull/11233
KAFKA-10847 improves stream-stream left/outer joins to avoid spurious
left/outer join results. However, it introduces regression bug
KAFKA-13216.
This PR disables KAFKA-10847 by partially rolling back KIP-633 changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #11233: HOTFIX: Disable spurious left/outer stream-stream join fix
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #11233:
URL: https://github.com/apache/kafka/pull/11233#issuecomment-903055614
As pointed out on the 3.0 release discussion thread on the dev mailing list, it's really about preserving a clean upgrade path from the old join semantics to the new join semantic. If we just undo the join-fix but keep the API change, how can we enable the join fix later without potentially breaking an existing application?
The idea was really, to enable the join-fix if the new API is used: his "forces" users to rewrite their code and to actively opt-in to the new join semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #11233: HOTFIX: Disable spurious left/outer stream-stream join fix
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #11233:
URL: https://github.com/apache/kafka/pull/11233#issuecomment-903069187
@mjsax , I found you forgot to rollback the doc part. I addressed in https://github.com/apache/kafka/pull/11247. If we merged this hotfix, then we should also merge the doc rollback. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mjsax commented on pull request #11233: HOTFIX: Disable spurious left/outer stream-stream join fix
Posted by GitBox <gi...@apache.org>.
mjsax commented on pull request #11233:
URL: https://github.com/apache/kafka/pull/11233#issuecomment-906091101
@showuon -- thanks for taking care of the docs -- I did actually not forget about it and was just about to do a follow up PR -- great that it is already done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang merged pull request #11233: HOTFIX: Disable spurious left/outer stream-stream join fix
Posted by GitBox <gi...@apache.org>.
guozhangwang merged pull request #11233:
URL: https://github.com/apache/kafka/pull/11233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org