You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/05/03 21:53:58 UTC

Re: Review Request 20284: Fixed post-reviews script to use 'rbt post' when 'post-review' is not available.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20284/
-----------------------------------------------------------

(Updated May 3, 2014, 7:53 p.m.)


Review request for mesos, Benjamin Hindman and Timothy St. Clair.


Changes
-------

Updated to use 'rbt post' if 'post-review' is not available. This should make it backwards compatible.


Summary (updated)
-----------------

Fixed post-reviews script to use 'rbt post' when 'post-review' is not available.


Bugs: MESOS-931
    https://issues.apache.org/jira/browse/MESOS-931


Repository: mesos-git


Description
-------

Note, for 'rbt post' to work correctly with revision ranges RBTools 0.5.4 or higher is needed.


Diffs (updated)
-----

  support/post-reviews.py 89ea779e856ef8c62819a45f3a942609baa75142 

Diff: https://reviews.apache.org/r/20284/diff/


Testing
-------

Used it post this review.


Thanks,

Vinod Kone


Re: Review Request 20284: Fixed post-reviews script to use 'rbt post' when 'post-review' is not available.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20284/#review42100
-----------------------------------------------------------

Ship it!


Rad, thanks Vinod.

- Benjamin Hindman


On May 3, 2014, 7:53 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20284/
> -----------------------------------------------------------
> 
> (Updated May 3, 2014, 7:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Timothy St. Clair.
> 
> 
> Bugs: MESOS-931
>     https://issues.apache.org/jira/browse/MESOS-931
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Note, for 'rbt post' to work correctly with revision ranges RBTools 0.5.4 or higher is needed.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 89ea779e856ef8c62819a45f3a942609baa75142 
> 
> Diff: https://reviews.apache.org/r/20284/diff/
> 
> 
> Testing
> -------
> 
> Used it post this review.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>