You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by markdingram <gi...@git.apache.org> on 2014/07/18 18:16:58 UTC

[GitHub] maven pull request: Fixes MNG-5663 - a regression introduced in 3....

GitHub user markdingram opened a pull request:

    https://github.com/apache/maven/pull/23

    Fixes MNG-5663 - a regression introduced in 3.2.2 by MNG-5639 that preve...

    ...nts
    
    nested import POMs from resolving their dependencies.
    
    The cuplrit was the resetRepositories method in tandem with the repository
    list instances being shared between ModelResolvers.
    
    - The copy constructor for the ModelResolvers now creates new lists.
    - The resetRepositories method has been removed. Instead there is a
    'replace' parameter on the addRepository method that allows the
    desired parameter replacement of MNG-5639 to take place.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markdingram/maven MNG-5663

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #23
    
----
commit e74a1333fc5f7b0bf36e38939aa7c5066481a564
Author: markdingram <ma...@gmail.com>
Date:   2014-07-18T15:59:09Z

    Fixes MNG-5663 - a regression introduced in 3.2.2 by MNG-5639 that prevents
    nested import POMs from resolving their dependencies.
    
    The cuplrit was the resetRepositories method in tandem with the repository
    list instances being shared between ModelResolvers.
    
    - The copy constructor for the ModelResolvers now creates new lists.
    - The resetRepositories method has been removed. Instead there is a
    'replace' parameter on the addRepository method that allows the
    desired parameter replacement of MNG-5639 to take place.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

[GitHub] maven pull request: Fixes MNG-5663 - a regression introduced in 3....

Posted by markdingram <gi...@git.apache.org>.
Github user markdingram commented on the pull request:

    https://github.com/apache/maven/pull/23#issuecomment-49514275
  
    already merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

[GitHub] maven pull request: Fixes MNG-5663 - a regression introduced in 3....

Posted by markdingram <gi...@git.apache.org>.
Github user markdingram closed the pull request at:

    https://github.com/apache/maven/pull/23


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org

[GitHub] maven pull request: Fixes MNG-5663 - a regression introduced in 3....

Posted by jvanzyl <gi...@git.apache.org>.
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/23#issuecomment-49457637
  
    Awesome! Thanks for looking into this, I'll review tonight and produce a build. I'll reach out Arnaud when I have the build and he can validate against the Exo build.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org