[GitHub] [arrow] westonpace commented on a diff in pull request #13069: ARROW-15901: [C++] Support flat custom output field names in Substrait

[GitBox <gi...@apache.org>]

westonpace commented on code in PR #13069:
URL: https://github.com/apache/arrow/pull/13069#discussion_r868409125


##########
cpp/src/arrow/compute/exec/sink_node.cc:
##########
@@ -263,18 +263,21 @@ class SinkNode : public ExecNode {
 class ConsumingSinkNode : public ExecNode, public BackpressureControl {
  public:
   ConsumingSinkNode(ExecPlan* plan, std::vector<ExecNode*> inputs,
-                    std::shared_ptr<SinkNodeConsumer> consumer)
+                    std::shared_ptr<SinkNodeConsumer> consumer,
+                    std::vector<std::string> names)
       : ExecNode(plan, std::move(inputs), {"to_consume"}, {},
                  /*num_outputs=*/0),
-        consumer_(std::move(consumer)) {}
+        consumer_(std::move(consumer)),
+        names_(names) {}

Review Comment:
   ```suggestion
           names_(std::move(names)) {}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org