You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/29 18:46:38 UTC
[GitHub] [airflow] fshehadeh opened a new pull request, #23370: Providers amazon
fshehadeh opened a new pull request, #23370:
URL: https://github.com/apache/airflow/pull/23370
Resolve an issue that can occur when reattaching to ECS tasks.
closes: https://github.com/apache/airflow/issues/22878
The code for fetching AWS logs, looks for the ecs_task_id field. When executing the task for the first time, this is updated after fetching the ARN for the first time. However, when the task is reattached to an existing ECS task, the current code will update the ARN, but will not update the ecs_task_id. The code change will ensure that the ecs_task_id is updated when the ARN is updated at the time of reattaching.
Note: this is a continuation of https://github.com/apache/airflow/pull/22879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23370: Fix attempting to reattach in `ECSOperator`
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #23370:
URL: https://github.com/apache/airflow/pull/23370#issuecomment-1114201108
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #23370: Fix attempting to reattach in `ECSOperator`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23370:
URL: https://github.com/apache/airflow/pull/23370#issuecomment-1114201032
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] fshehadeh commented on pull request #23370: Providers amazon
Posted by GitBox <gi...@apache.org>.
fshehadeh commented on PR #23370:
URL: https://github.com/apache/airflow/pull/23370#issuecomment-1113618194
@potiuk: does this look right now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #23370: Fix attempting to reattach in `ECSOperator`
Posted by GitBox <gi...@apache.org>.
eladkal merged PR #23370:
URL: https://github.com/apache/airflow/pull/23370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org