You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sravya Tirukkovalur <sr...@cloudera.com> on 2014/09/15 23:37:16 UTC
Review Request 25665: SENTRY-380: Clean up some grantorPrincipal
semantics
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25665/
-----------------------------------------------------------
Review request for sentry and Prasad Mujumdar.
Bugs: sentry-380
https://issues.apache.org/jira/browse/sentry-380
Repository: sentry
Description
-------
Cleaning up the use of grantorPrincipal in creating roles/groups. Created a follow on jira to update the jdo and the models to store grantorPrincipal as part of the mapping: SENTRY-440.
Note: Will update the patch with the upgrade scripts if the changes look ok.
Diffs
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 4f34de6bfcb3d271fd3bd5eb9f0aae745ad7d7f3
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGroup.java 3f68f0d04e76d1a3a70aa3a1280046df858c4e6a
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java 5328fff96b6f3b2a162b7afd370e7435bfc78caa
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 912ed95efab051215e949dd8b7d6b64430491886
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo b39cb18ed10eea476dc1627a221353c92ee59c57
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 718306d23cd3244993757f82489c84adea65411e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 63582891e781a553f89038c5efa7bedf247b1b7e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 070c494c099cd4749e4b61ac43fc1b9537f55c6b
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.5.0.sql 785c8857e65ae8669a8cedda6ac651869b4e4e38
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.5.0.sql 785c8857e65ae8669a8cedda6ac651869b4e4e38
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.5.0.sql f94f6bd71f3a2e0c7d1ee12b69fc62e2fc9b1856
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.5.0.sql 35dbc5b23929abbdc4bcd84fae64b2677f8f5963
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.5.0.sql 1d6036f94e663fd6d700231156098d84b308472e
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift b14616b7058a5ddcec3e7d544bea5bd957e093b2
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 985a73d2f5a3f57dd006e1c6c626798cce46eacc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 066e909bce8fb9f236a69c814f0f90b4865020fd
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImport.java c238361ad2f513a5450dfea9b2611ac6a5bf3852
Diff: https://reviews.apache.org/r/25665/diff/
Testing
-------
Failing tests due to null constraint on Grantor principal now pass on a real postgres backed cluster. Rerunning the entire suite locally.
Thanks,
Sravya Tirukkovalur
Re: Review Request 25665: SENTRY-380: Clean up some grantorPrincipal
semantics
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25665/#review53642
-----------------------------------------------------------
Ship it!
LGTM
Please file a followup ticket to fix the upgrade scripts. Thanks
- Prasad Mujumdar
On Sept. 15, 2014, 11:38 p.m., Sravya Tirukkovalur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25665/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2014, 11:38 p.m.)
>
>
> Review request for sentry and Prasad Mujumdar.
>
>
> Bugs: sentry-380
> https://issues.apache.org/jira/browse/sentry-380
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Cleaning up the use of grantorPrincipal in creating roles/groups. Created a follow on jira to update the jdo and the models to store grantorPrincipal as part of the mapping: SENTRY-440.
>
> Note: Will update the patch with the upgrade scripts if the changes look ok.
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 4f34de6bfcb3d271fd3bd5eb9f0aae745ad7d7f3
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGroup.java 3f68f0d04e76d1a3a70aa3a1280046df858c4e6a
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java 5328fff96b6f3b2a162b7afd370e7435bfc78caa
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 912ed95efab051215e949dd8b7d6b64430491886
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo b39cb18ed10eea476dc1627a221353c92ee59c57
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 718306d23cd3244993757f82489c84adea65411e
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 63582891e781a553f89038c5efa7bedf247b1b7e
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 070c494c099cd4749e4b61ac43fc1b9537f55c6b
> sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.5.0.sql 785c8857e65ae8669a8cedda6ac651869b4e4e38
> sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.5.0.sql 785c8857e65ae8669a8cedda6ac651869b4e4e38
> sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.5.0.sql f94f6bd71f3a2e0c7d1ee12b69fc62e2fc9b1856
> sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.5.0.sql 35dbc5b23929abbdc4bcd84fae64b2677f8f5963
> sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.5.0.sql 1d6036f94e663fd6d700231156098d84b308472e
> sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift b14616b7058a5ddcec3e7d544bea5bd957e093b2
> sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 985a73d2f5a3f57dd006e1c6c626798cce46eacc
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 066e909bce8fb9f236a69c814f0f90b4865020fd
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMovingToProduction.java 6fad40dcd9146e0e49b00287a2d24b4e42758f9e
> sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImport.java c238361ad2f513a5450dfea9b2611ac6a5bf3852
>
> Diff: https://reviews.apache.org/r/25665/diff/
>
>
> Testing
> -------
>
> Failing tests due to null constraint on Grantor principal now pass on a real postgres backed cluster. Rerunning the entire suite locally.
>
>
> Thanks,
>
> Sravya Tirukkovalur
>
>
Re: Review Request 25665: SENTRY-380: Clean up some grantorPrincipal
semantics
Posted by Sravya Tirukkovalur <sr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25665/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 11:38 p.m.)
Review request for sentry and Prasad Mujumdar.
Changes
-------
Deprecating the required field in thrift to maintain backward compatibility.
Also, TestDbMovingToProduction was intermittently failing as it was not overriding the setup method correctly, fixed it now.
Bugs: sentry-380
https://issues.apache.org/jira/browse/sentry-380
Repository: sentry
Description
-------
Cleaning up the use of grantorPrincipal in creating roles/groups. Created a follow on jira to update the jdo and the models to store grantorPrincipal as part of the mapping: SENTRY-440.
Note: Will update the patch with the upgrade scripts if the changes look ok.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 4f34de6bfcb3d271fd3bd5eb9f0aae745ad7d7f3
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGroup.java 3f68f0d04e76d1a3a70aa3a1280046df858c4e6a
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java 5328fff96b6f3b2a162b7afd370e7435bfc78caa
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java 912ed95efab051215e949dd8b7d6b64430491886
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo b39cb18ed10eea476dc1627a221353c92ee59c57
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 718306d23cd3244993757f82489c84adea65411e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 63582891e781a553f89038c5efa7bedf247b1b7e
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 070c494c099cd4749e4b61ac43fc1b9537f55c6b
sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.5.0.sql 785c8857e65ae8669a8cedda6ac651869b4e4e38
sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.5.0.sql 785c8857e65ae8669a8cedda6ac651869b4e4e38
sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.5.0.sql f94f6bd71f3a2e0c7d1ee12b69fc62e2fc9b1856
sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.5.0.sql 35dbc5b23929abbdc4bcd84fae64b2677f8f5963
sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.5.0.sql 1d6036f94e663fd6d700231156098d84b308472e
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift b14616b7058a5ddcec3e7d544bea5bd957e093b2
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 985a73d2f5a3f57dd006e1c6c626798cce46eacc
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 066e909bce8fb9f236a69c814f0f90b4865020fd
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMovingToProduction.java 6fad40dcd9146e0e49b00287a2d24b4e42758f9e
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImport.java c238361ad2f513a5450dfea9b2611ac6a5bf3852
Diff: https://reviews.apache.org/r/25665/diff/
Testing
-------
Failing tests due to null constraint on Grantor principal now pass on a real postgres backed cluster. Rerunning the entire suite locally.
Thanks,
Sravya Tirukkovalur