[GitHub] piiswrong commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.

[GitBox <gi...@apache.org>]

piiswrong commented on a change in pull request #8972: Profiling enhancements, python API, vtune and chrome tracing objects, etc.
URL: https://github.com/apache/incubator-mxnet/pull/8972#discussion_r155399240
 
 

 ##########
 File path: python/mxnet/profiler.py
 ##########
 @@ -35,10 +35,23 @@ def profiler_set_config(mode='symbolic', filename='profile.json'):
     filename : string, optional
         The name of output trace file. Defaults to 'profile.json'.
     """
-    mode2int = {'symbolic': 0, 'all': 1}
-    check_call(_LIB.MXSetProfilerConfig(
-        ctypes.c_int(mode2int[mode]),
-        c_str(filename)))
+    mode2int = {'symbolic': 1,
 
 Review comment:
   do this in backend with dmlc::parameter

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services