MEECROWAVE_BASE

[Mark Struberg <st...@yahoo.de.INVALID>]

Hi folks!

I still struggle a bit with our implementation of MEECROWAVE_BASE and especially our code in Meecrowave#newBaseDir().

First, for all who have no idea about what I am talking about: please read about the difference between Tomcat CATALINA_HOME vs CATALINA_BASE. 
This is for supporting a split between having one binary installation (the libs) vs multiple webapps in separate JVMs, which can have different config.
CATALINA_HOME is the location of the binary, vs CATALINA_BASE is the location of the conf, webapp, etc.

So how should our MEECROWAVE_BASE behave?

If it would be an 1:1 analogon to CATALINA_BASE? Currently this doesn't seem to be the case as we create a temp folder each time:

if (baseDir.isPresent()) {
    file = new File(baseDir.get(), "meecrowave-" + System.nanoTime());
} else {
    file = ownedTempDir;
}

This is perfect for development, but is it ok for production?
We currently always create an empty temp folder which will effectively not be used afaict. Doesn't hurt, but just confuses and makes no sense imo.


LieGrue,
strub

Re: MEECROWAVE_BASE

[Romain Manni-Bucau <rm...@gmail.com>]

Think we (you can blame me ;)) never did the final step to be aligned on
tomcat here.

Long story short we must keep the same good default for all cases except
the bundle/zip case in its two forms (base=home or home != base).

In this last case we must just use the provided base.

Idea is to add --dir in our scripts (sh with cygwin support and bat) and
keep the rest of the logic for dev/shades etc.

Wdyt?

Le 1 mai 2018 11:04, "Mark Struberg" <st...@yahoo.de.invalid> a écrit :

> Hi folks!
>
> I still struggle a bit with our implementation of MEECROWAVE_BASE and
> especially our code in Meecrowave#newBaseDir().
>
> First, for all who have no idea about what I am talking about: please read
> about the difference between Tomcat CATALINA_HOME vs CATALINA_BASE.
> This is for supporting a split between having one binary installation (the
> libs) vs multiple webapps in separate JVMs, which can have different config.
> CATALINA_HOME is the location of the binary, vs CATALINA_BASE is the
> location of the conf, webapp, etc.
>
> So how should our MEECROWAVE_BASE behave?
>
> If it would be an 1:1 analogon to CATALINA_BASE? Currently this doesn't
> seem to be the case as we create a temp folder each time:
>
> if (baseDir.isPresent()) {
>     file = new File(baseDir.get(), "meecrowave-" + System.nanoTime());
> } else {
>     file = ownedTempDir;
> }
>
> This is perfect for development, but is it ok for production?
> We currently always create an empty temp folder which will effectively not
> be used afaict. Doesn't hurt, but just confuses and makes no sense imo.
>
>
> LieGrue,
> strub