You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by lavacat <gi...@git.apache.org> on 2018/08/23 21:11:31 UTC
[GitHub] zookeeper pull request #607: WIP - ZOOKEEPER-2990: Implement probabilistic t...
GitHub user lavacat opened a pull request:
https://github.com/apache/zookeeper/pull/607
WIP - ZOOKEEPER-2990: Implement probabilistic tracing
- stmk can be called with extra list of 10 short numbers to set the rate for each mask bit. Max rate is 1000
example: perl -e "print 'stmk', pack('q>s>s>s>s>s>s>s>s>s>s>', 0b0011111010, 0, 100, 200, 300, 400, 500, 600, 7, 8, 9)"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lavacat/zookeeper branch-3.4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/607.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #607
----
commit 45e7f7933e42aa8f2a06d91cb53044c113ccc9ff
Author: Bogdan Kanivets <bk...@...>
Date: 2018-08-23T20:42:53Z
ZOOKEEPER-2990: Implement probabilistic tracing
- stmk can be called with extra list of 10 short numbers to set the rate for each mask bit. Max rate is 1000
example: perl -e "print 'stmk', pack('q>s>s>s>s>s>s>s>s>s>s>', 0b0011111010, 0, 100, 200, 300, 400, 500, 600, 7, 8, 9)"
----
---
[GitHub] zookeeper issue #607: WIP - ZOOKEEPER-2990: Implement probabilistic tracing
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/607
Basically my biggest concern is that this patch shouldn't go into 3.4, because it's not critical.
3.5 is just around the corner and improvements like this will encourage people to upgrade once stable version is available.
---
[GitHub] zookeeper issue #607: WIP - ZOOKEEPER-2990: Implement probabilistic tracing
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/607
Thanks for the contribution @lavacat .
Please take a look at my comments in the Jira.
---