You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ti...@apache.org on 2013/05/23 23:43:35 UTC

[4/4] git commit: Testing various plugins

Testing various plugins


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugman/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugman/commit/f043c347
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugman/tree/f043c347
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugman/diff/f043c347

Branch: refs/heads/master
Commit: f043c347510e4274298005e69e62713061e678ee
Parents: ec82bfa
Author: Tim Kim <ti...@adobe.com>
Authored: Wed May 22 15:06:27 2013 -0700
Committer: Tim Kim <ti...@adobe.com>
Committed: Thu May 23 14:43:10 2013 -0700

----------------------------------------------------------------------
 spec/install.spec.js |    2 --
 src/install.js       |    2 +-
 2 files changed, 1 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/f043c347/spec/install.spec.js
----------------------------------------------------------------------
diff --git a/spec/install.spec.js b/spec/install.spec.js
index fba0719..83c3811 100644
--- a/spec/install.spec.js
+++ b/spec/install.spec.js
@@ -210,7 +210,5 @@ describe('install', function() {
                 done();
             });
         });
-        if('should throw if cordova version isn\'t high enough', function(){
-        });
     });
 });

http://git-wip-us.apache.org/repos/asf/cordova-plugman/blob/f043c347/src/install.js
----------------------------------------------------------------------
diff --git a/src/install.js b/src/install.js
index 6b73822..0c92701 100644
--- a/src/install.js
+++ b/src/install.js
@@ -77,7 +77,7 @@ function runInstall(actions, platform, project_dir, plugin_dir, plugins_dir, cli
         if(engine.attrib["name"].toLowerCase() === "cordova"){
             var engineVersion = engine.attrib["version"];
             var versionPath = path.join(project_dir, 'cordova', 'version');
-
+            
             // need to rethink this so I don't have to chmod anything
             fs.chmodSync(versionPath, '755');