You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/06/16 02:44:39 UTC
[GitHub] [thrift] cfriedt opened a new pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
cfriedt opened a new pull request #1996:
URL: https://github.com/apache/thrift/pull/1996
As of v0.13.0 but probably earlier, and with at least C++, the code generator did not verify that required fields were present on outgoing messages.
This change ensures that the struct writer throws an exception if a required field is not present.
Note, I have not yet added an integration test
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] cfriedt commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
cfriedt commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-674509722
I should rebase again. So swamped atm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-639072614
A rebase seems needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] cfriedt commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
cfriedt commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-695815054
Rebased.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-643452431
@cfriedt This needs a rebase, could you do that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-748615031
This issue has been automatically closed due to inactivity. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-641587581
Ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] cfriedt closed pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
cfriedt closed pull request #1996:
URL: https://github.com/apache/thrift/pull/1996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-743934741
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] cfriedt commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
cfriedt commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-644488645
In progress
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] cfriedt commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
cfriedt commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-695815054
Rebased.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-674344751
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] closed pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #1996:
URL: https://github.com/apache/thrift/pull/1996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] stale[bot] commented on pull request #1996: THRIFT-5079: Check presence of required fields in struct writer
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #1996:
URL: https://github.com/apache/thrift/pull/1996#issuecomment-674509727
This issue is no longer stale. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org