You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@airavata.apache.org by hiteshkumardasika <gi...@git.apache.org> on 2017/09/26 02:49:21 UTC
[GitHub] airavata pull request #122: Initial Commit for Airavata PGA Dockerfile
GitHub user hiteshkumardasika opened a pull request:
https://github.com/apache/airavata/pull/122
Initial Commit for Airavata PGA Dockerfile
Created Dockerfile for Airavata PGA Installation
Dockerfile still needs lot of changes. Image can be built and container can be started but still there are some configurations that need to be changed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hiteshkumardasika/airavata docker_pga
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/airavata/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit 4f8b97b968f51afe70dd72e1f9a3b84110d73027
Author: hiteshkumardasika <hd...@indiana.edu>
Date: 2017-09-26T02:40:03Z
Initial Commit for Airavata PGA Dockerfile
----
---
[GitHub] airavata pull request #122: Initial Commit for Airavata PGA Dockerfile
Posted by Ameya05 <gi...@git.apache.org>.
Github user Ameya05 commented on a diff in the pull request:
https://github.com/apache/airavata/pull/122#discussion_r144340526
--- Diff: dev-tools/docker/Dockerfiles/pga_config.php.j2 ---
@@ -11,88 +11,80 @@ return array(
/**
* Admin Role Name
*/
- 'admin-role-name' => '{{ admin_role_name }}',
+ 'admin-role-name' => 'admin',
/**
* Read only Admin Role Name
*/
- 'read-only-admin-role-name' => '{{ admin_readonly_role_name }}',
+ 'read-only-admin-role-name' => 'admin-read-only',
/**
* Gateway user role
*/
- 'user-role-name' => '{{ user_role_name }}',
+ 'user-role-name' => 'gateway-user',
/**
* Initial user role. This is the initial user role assigned to a new
* user. Set this to one of the three roles above to automatically
* grant new users that role, or set to some other role ('user-pending')
* to require admin approval before users have access.
*/
- 'initial-role-name' => '{{ initial_role_name }}',
+ 'initial-role-name' => 'user-pending',
/**
* Tenant Domain
*/
- 'tenant-domain' => '{{ tenant_domain }}',
+ 'tenant-domain' => 'test-gateway',
/**
* Tenant admin's username
*/
- 'admin-username' => '{{ admin_username }}',
+ 'admin-username' => 'admin',
/**
* Tenant admin's password
*/
- 'admin-password' => '{{ admin_password }}',
+ 'admin-password' => 'admin',
--- End diff --
I don't think this file with sensitive content should be checked into repository. Although the passwords seem to be for your local installation, it would be better if u revert it to the {{ variable }} version.
---
[GitHub] airavata pull request #122: Initial Commit for Airavata PGA Dockerfile
Posted by hiteshkumardasika <gi...@git.apache.org>.
Github user hiteshkumardasika commented on a diff in the pull request:
https://github.com/apache/airavata/pull/122#discussion_r144354208
--- Diff: dev-tools/docker/Dockerfiles/pga_config.php.j2 ---
@@ -11,88 +11,80 @@ return array(
/**
* Admin Role Name
*/
- 'admin-role-name' => '{{ admin_role_name }}',
+ 'admin-role-name' => 'admin',
/**
* Read only Admin Role Name
*/
- 'read-only-admin-role-name' => '{{ admin_readonly_role_name }}',
+ 'read-only-admin-role-name' => 'admin-read-only',
/**
* Gateway user role
*/
- 'user-role-name' => '{{ user_role_name }}',
+ 'user-role-name' => 'gateway-user',
/**
* Initial user role. This is the initial user role assigned to a new
* user. Set this to one of the three roles above to automatically
* grant new users that role, or set to some other role ('user-pending')
* to require admin approval before users have access.
*/
- 'initial-role-name' => '{{ initial_role_name }}',
+ 'initial-role-name' => 'user-pending',
/**
* Tenant Domain
*/
- 'tenant-domain' => '{{ tenant_domain }}',
+ 'tenant-domain' => 'test-gateway',
/**
* Tenant admin's username
*/
- 'admin-username' => '{{ admin_username }}',
+ 'admin-username' => 'admin',
/**
* Tenant admin's password
*/
- 'admin-password' => '{{ admin_password }}',
+ 'admin-password' => 'admin',
--- End diff --
But these configurations cannot be parameterized as these files directly go into the docker container through Dockerfile. To test the installation, these values are not parameterized.
---