[GitHub] [airflow] emredjan commented on pull request #31349: Fix the deprecated parameter in hvac client

["emredjan (via GitHub)" <gi...@apache.org>]

emredjan commented on PR #31349:
URL: https://github.com/apache/airflow/pull/31349#issuecomment-1551318437

   > Here is an example to how we provide arguments based on the lib version:
   
   Thanks for the guidance, I'm looking at how I can provide the argument based on the library version, unfortunately `hvac` does not seem to implement the `__version__` attribute.
   
   ```python
   >>> import hvac
   >>> hvac.__version__
   Traceback (most recent call last):
     File "<stdin>", line 1, in <module>
   AttributeError: module 'hvac' has no attribute '__version__'
   ```
   
   Would it be acceptable to implement this via the `importlib`, or would that be unnecessary overhead?
   
   ```python
   >>> from importlib.metadata import version
   >>> version('hvac')
   '1.1.0'
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org