You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/04/12 15:21:00 UTC
[jira] [Work logged] (BEAM-14299) [BigqueryIO] MoreObjects.firstNonNull should not be called with null
[ https://issues.apache.org/jira/browse/BEAM-14299?focusedWorklogId=755824&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755824 ]
ASF GitHub Bot logged work on BEAM-14299:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Apr/22 15:20
Start Date: 12/Apr/22 15:20
Worklog Time Spent: 10m
Work Description: zhengbuqian opened a new pull request, #17349:
URL: https://github.com/apache/beam/pull/17349
[BEAM-14299](https://issues.apache.org/jira/browse/BEAM-14299): if `streamName.read()` returns null, [firstNonNull](https://guava.dev/releases/20.0/api/docs/com/google/common/base/MoreObjects.html#firstNonNull-T-T-) will throw NullPointerException. We check the nullness in the next line so it's ok for stream to be null, we should assign streamName.read() to stream directly.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
Issue Time Tracking
-------------------
Worklog Id: (was: 755824)
Remaining Estimate: 0h
Time Spent: 10m
> [BigqueryIO] MoreObjects.firstNonNull should not be called with null
> --------------------------------------------------------------------
>
> Key: BEAM-14299
> URL: https://issues.apache.org/jira/browse/BEAM-14299
> Project: Beam
> Issue Type: Bug
> Components: io-java-gcp
> Reporter: Buqian Zheng
> Assignee: Buqian Zheng
> Priority: P1
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/2e0f79ef2b924da3306d0e55dffd4728809b9f3d/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWritesShardedRecords.java#L516] if streamName.read() returns null, [firstNonNull|https://guava.dev/releases/20.0/api/docs/com/google/common/base/MoreObjects.html#firstNonNull-T-T-] will throw NullPointerException. We check the nullness in the next line so it's ok for stream to be null, we should assign streamName.read() to stream directly.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)