svn commit: r1776793 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/Base64Encoder.java

[pm...@apache.org]

Author: pmouawad
Date: Sat Dec 31 16:07:43 2016
New Revision: 1776793

URL: http://svn.apache.org/viewvc?rev=1776793&view=rev
Log:
Sonar : fix squid:S00115 "Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'"
Deprecated it and Mention breaking change in changes.xml

Modified:
    jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/Base64Encoder.java

Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/Base64Encoder.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/Base64Encoder.java?rev=1776793&r1=1776792&r2=1776793&view=diff
==============================================================================
--- jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/Base64Encoder.java (original)
+++ jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/util/Base64Encoder.java Sat Dec 31 16:07:43 2016
@@ -22,14 +22,15 @@ package org.apache.jmeter.protocol.http.
  * This class provides an implementation of Base64 encoding without relying on
  * the sun.* packages.
  *
- * @version $Revision$
+ * @deprecated as exists now in java.util.Base64, will be removed in next version 3.3
  */
+@Deprecated
 public final class Base64Encoder {
     private static final char[] pem_array = { 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82,
             83, 84, 85, 86, 87, 88, 89, 90, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111,
             112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 43, 47 };
 
-    private static final char eq = 61;
+    private static final char EQ = 61;
 
     /**
      * Private constructor to prevent instantiation.
@@ -57,8 +58,8 @@ public final class Base64Encoder {
             int k = 0;
             out.append(String.valueOf(pem_array[b1 >>> 2 & 63]));
             out.append(String.valueOf(pem_array[(b1 << 4 & 48) + (k >>> 4 & 15)]));
-            out.append(String.valueOf(eq));
-            out.append(String.valueOf(eq));
+            out.append(String.valueOf(EQ));
+            out.append(String.valueOf(EQ));
             return out.toString();
         }
         if (left == 2) {
@@ -68,7 +69,7 @@ public final class Base64Encoder {
             out.append(String.valueOf(pem_array[b2 >>> 2 & 63]));
             out.append(String.valueOf(pem_array[(b2 << 4 & 48) + (b4 >>> 4 & 15)]));
             out.append(String.valueOf(pem_array[(b4 << 2 & 60) + (l >>> 6 & 3)]));
-            out.append(String.valueOf(eq));
+            out.append(String.valueOf(EQ));
             return out.toString();
         }
         byte b3 = b[strt];