You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by szheng79 <gi...@git.apache.org> on 2015/04/21 21:39:29 UTC
[GitHub] spark pull request: Add support on type NVARCHAR
GitHub user szheng79 opened a pull request:
https://github.com/apache/spark/pull/5618
Add support on type NVARCHAR
Issue:
https://issues.apache.org/jira/browse/SPARK-7039
Add support to column type NVARCHAR in Sql Server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/szheng79/spark patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5618.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5618
----
commit eab0bd8b43f67b0b6c6b0648ec6282760fbb0a34
Author: szheng79 <sz...@gmail.com>
Date: 2015-04-21T19:37:27Z
Add support on type NVARCHAR
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: JDBCRDD: Add to support on type NVARCHAR
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/5618#issuecomment-94921384
@szheng79 Please review https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark -- you need to update the title of this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: JDBCRDD: Add to support on type NVARCHAR
Posted by szheng79 <gi...@git.apache.org>.
Github user szheng79 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5618#discussion_r28876804
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRDD.scala ---
@@ -60,6 +60,7 @@ private[sql] object JDBCRDD extends Logging {
case java.sql.Types.NCLOB => StringType
case java.sql.Types.NULL => null
case java.sql.Types.NUMERIC => DecimalType.Unlimited
+ case java.sql.Types.NVARCHAR => StringType
--- End diff --
Fixed, I thought I made aligning, but I guess it caused by mixing space and tab, now I all use tab there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7039][SQL]JDBCRDD: Add support on type ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5618#issuecomment-95285974
Jenkins, test this please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7039][SQL]JDBCRDD: Add support on type ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5618#issuecomment-95287289
[Test build #30772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30772/consoleFull) for PR 5618 at commit [`10da99c`](https://github.com/apache/spark/commit/10da99c1707bdf374d0d8e427d73250c7027a1d3).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: JDBCRDD: Add to support on type NVARCHAR
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5618#discussion_r28820277
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JDBCRDD.scala ---
@@ -60,6 +60,7 @@ private[sql] object JDBCRDD extends Logging {
case java.sql.Types.NCLOB => StringType
case java.sql.Types.NULL => null
case java.sql.Types.NUMERIC => DecimalType.Unlimited
+ case java.sql.Types.NVARCHAR => StringType
--- End diff --
do u mind aligning the arrows?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7039][SQL]JDBCRDD: Add support on type ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/5618
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #5618: [SPARK-7039][SQL]JDBCRDD: Add support on type NVARCHAR
Posted by robbyki <gi...@git.apache.org>.
Github user robbyki commented on the issue:
https://github.com/apache/spark/pull/5618
How can I create a schema outside of spark containing columns with varchar and nvarchar and then save a dataframe with truncate = true and avoid an invalid datatype error for TEXT in Netezza by registering a new dialect? My current dialect has StringType mapped to either varchar or nvarchar but I can't have both and I'm failing to understand how to customize and persists table schemas without my dialects over-writing everything. Using spark 2.1.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7039][SQL]JDBCRDD: Add support on type ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/5618#issuecomment-95315015
[Test build #30772 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30772/consoleFull) for PR 5618 at commit [`10da99c`](https://github.com/apache/spark/commit/10da99c1707bdf374d0d8e427d73250c7027a1d3).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
* This patch does not change any dependencies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7039][SQL]JDBCRDD: Add support on type ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5618#issuecomment-95315031
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/30772/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Add support on type NVARCHAR
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/5618#issuecomment-94916039
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-7039][SQL]JDBCRDD: Add support on type ...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/5618#issuecomment-95320129
Thanks. I've merged this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org