You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@singa.apache.org by GitBox <gi...@apache.org> on 2020/08/04 13:02:31 UTC

[GitHub] [singa] joddiy opened a new pull request #778: Add ro ber ta model

joddiy opened a new pull request #778:
URL: https://github.com/apache/singa/pull/778


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] joddiy commented on pull request #778: Add roberta model

Posted by GitBox <gi...@apache.org>.
joddiy commented on pull request #778:
URL: https://github.com/apache/singa/pull/778#issuecomment-691674560


   ready to merge after #794 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #778: Add roberta model

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #778:
URL: https://github.com/apache/singa/pull/778#issuecomment-683376235


   This pull request **introduces 1 alert** when merging 6de753a92a1358c6d8f9c5784f63dca0568020a9 into a93aaee03c295113ca30dbeecb0039d1f2b8f15d - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-2fb7e159158d44db506b9ed1708160f542f8fd66)
   
   **new alerts:**
   
   * 1 for Unused import


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] codecov[bot] commented on pull request #778: Add roberta model

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #778:
URL: https://github.com/apache/singa/pull/778#issuecomment-691674465


   # [Codecov](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=h1) Report
   > Merging [#778](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/ded7ca88bd0b4d5a5dc3674ecec7abebea49cfbd?el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/778/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev     #778      +/-   ##
   ==========================================
   - Coverage   70.06%   65.09%   -4.98%     
   ==========================================
     Files         100       86      -14     
     Lines       11568     4804    -6764     
   ==========================================
   - Hits         8105     3127    -4978     
   + Misses       3463     1677    -1786     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.09% <71.42%> (-0.03%)` | :arrow_down: |
   | #singa-python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-8.79%)` | :arrow_down: |
   | [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `76.54% <100.00%> (+0.34%)` | :arrow_up: |
   | [layer.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-bGF5ZXIucHk=) | | |
   | [autograd.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-YXV0b2dyYWQucHk=) | | |
   | [image\_tool.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | | |
   | [opt.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-b3B0LnB5) | | |
   | [utils.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-dXRpbHMucHk=) | | |
   | [device.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | | |
   | [model.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | | |
   | [data.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-ZGF0YS5weQ==) | | |
   | ... and [6 more](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=footer). Last update [ded7ca8...cc7c6b3](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] nudles merged pull request #778: Add roberta model

Posted by GitBox <gi...@apache.org>.
nudles merged pull request #778:
URL: https://github.com/apache/singa/pull/778


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] dcslin commented on pull request #778: Add roberta model

Posted by GitBox <gi...@apache.org>.
dcslin commented on pull request #778:
URL: https://github.com/apache/singa/pull/778#issuecomment-688730247


   > Hi, shicong, @dcslin , it seems, we need to upgrade the Matmul operator to support high dimensions.
   > 
   > For eaxmple:
   > (1, 7, 768) * (768, 768)
   > (1, 12, 7, 64) * (1, 12, 64, 7)
   
   We need to add broadcasting to matmul. still checking


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] joddiy commented on pull request #778: Add ro ber ta model

Posted by GitBox <gi...@apache.org>.
joddiy commented on pull request #778:
URL: https://github.com/apache/singa/pull/778#issuecomment-669944322


   it seems the model has some problems, I have reported an issue to the onnx, hope they can check it...
   
   https://github.com/onnx/models/issues/351


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] joddiy commented on pull request #778: Add roberta model

Posted by GitBox <gi...@apache.org>.
joddiy commented on pull request #778:
URL: https://github.com/apache/singa/pull/778#issuecomment-688262171


   Hi, shicong, @dcslin , it seems, we need to upgrade the Matmul operator to support high dimensions.
   
   For eaxmple:
   (1, 7, 768) * (768, 768)
   (1, 12, 7, 64) * (1, 12, 64, 7)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #778: Add roberta model

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #778:
URL: https://github.com/apache/singa/pull/778#issuecomment-691676156


   This pull request **introduces 1 alert** when merging cc7c6b3171aee4bb7033bbdcfad0ed04e5872bc1 into 0d79d526a3e7fcb621614da2e13882a06cdf6634 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-d8fcd299d28425b7717d0376c4b7887d070163ae)
   
   **new alerts:**
   
   * 1 for Unused import


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] lgtm-com[bot] commented on pull request #778: Add ro ber ta model

Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #778:
URL: https://github.com/apache/singa/pull/778#issuecomment-668594409


   This pull request **introduces 1 alert** when merging fbdacb02731719e1b4f5335d7999b5cc6a0adc83 into 3014944996b089c61e7201350eaae3e8f6a0bdd2 - [view on LGTM.com](https://lgtm.com/projects/g/apache/singa/rev/pr-825908d5d91a4119331d543ab167fdf58d63503a)
   
   **new alerts:**
   
   * 1 for Unused import


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [singa] codecov[bot] edited a comment on pull request #778: Add roberta model

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #778:
URL: https://github.com/apache/singa/pull/778#issuecomment-691674465


   # [Codecov](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=h1) Report
   > Merging [#778](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/singa/commit/ded7ca88bd0b4d5a5dc3674ecec7abebea49cfbd?el=desc) will **decrease** coverage by `4.97%`.
   > The diff coverage is `71.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/singa/pull/778/graphs/tree.svg?width=650&height=150&src=pr&token=raMbqTl5Tl)](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              dev     #778      +/-   ##
   ==========================================
   - Coverage   70.06%   65.09%   -4.98%     
   ==========================================
     Files         100       86      -14     
     Lines       11568     4804    -6764     
   ==========================================
   - Hits         8105     3127    -4978     
   + Misses       3463     1677    -1786     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #singa-cpp | `65.09% <71.42%> (-0.03%)` | :arrow_down: |
   | #singa-python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [include/singa/core/tensor.h](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-aW5jbHVkZS9zaW5nYS9jb3JlL3RlbnNvci5o) | `73.21% <0.00%> (-8.79%)` | :arrow_down: |
   | [src/core/tensor/tensor.cc](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdGVuc29yL3RlbnNvci5jYw==) | `76.54% <100.00%> (+0.34%)` | :arrow_up: |
   | [singa\_wrap.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-c2luZ2Ffd3JhcC5weQ==) | | |
   | [data.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-ZGF0YS5weQ==) | | |
   | [layer.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-bGF5ZXIucHk=) | | |
   | [image\_tool.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-aW1hZ2VfdG9vbC5weQ==) | | |
   | [opt.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-b3B0LnB5) | | |
   | [sonnx.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-c29ubngucHk=) | | |
   | [model.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-bW9kZWwucHk=) | | |
   | [device.py](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree#diff-ZGV2aWNlLnB5) | | |
   | ... and [6 more](https://codecov.io/gh/apache/singa/pull/778/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=footer). Last update [ded7ca8...cc7c6b3](https://codecov.io/gh/apache/singa/pull/778?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org