[GitHub] [druid] gianm edited a comment on issue #8728: Initial join support

[GitBox <gi...@apache.org>]

gianm edited a comment on issue #8728: Initial join support
URL: https://github.com/apache/druid/issues/8728#issuecomment-576402224
 
 
   > * I think what's missing here as well is a bit of discussion on the ingestion side of dimension tables.
   
   I agree. I haven't thought a ton about how it should work. But I think, ideally, it'd use the new InputFormat and InputSource stuff so users don't have to learn new concepts. It would be great if it used tasks too for even more conceptual-weight-reduction.
   
   > * You mention "master datasource" under Broker Behavior. First time it's mentioned in this doc. With no prior explanation. Do you mean the base datasource?
   
   I meant the datasource that the user provided in the query. I'll edit to make it clearer.
   
   > * Under Test Plan it would be good to see some more comprehensive sets of queries that you expect to be supported and others that won't be, ideally in order of complexity. Perhaps we can use that to stage implementation phases by scoping them to supported query types?
   
   That is a great idea. I will plan to add that when the SQL part starts getting fleshed out more.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org