You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/02/06 18:02:26 UTC

Review Request 30735: We should be doing disk space check before deploying cluster and/or RU

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30735/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.


Bugs: AMBARI-9523
    https://issues.apache.org/jira/browse/AMBARI-9523


Repository: ambari


Description
-------

It is not a strictly RU issue, but we face it more often when performing RU on a disk-limited instance. So, we should check disk space and warn user if he is likely to have problems.
We should be doing disk space check on the disk mount for /usr/hdp. Also, it seems like we need to take apt cache into account when calculating available space.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/HostInfo.py 2c707b2 
  ambari-server/src/main/resources/host_scripts/alert_disk_space.py 8208ac5 
  ambari-server/src/test/python/host_scripts/_TestAlertDiskSpace.py PRE-CREATION 
  ambari-server/src/test/python/unitTests.py e812b83 

Diff: https://reviews.apache.org/r/30735/diff/


Testing
-------

[INFO] Reactor Summary:
[INFO] 
[INFO] Ambari Views ...................................... SUCCESS [2.171s]
[INFO] Ambari Server ..................................... SUCCESS [28.554s]
[INFO] Ambari Agent ...................................... SUCCESS [16.160s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 47.456s
[INFO] Finished at: Fri Feb 06 20:02:19 FET 2015
[INFO] Final Memory: 48M/417M
[INFO] ------------------------------------------------------------------------


Thanks,

Dmitro Lisnichenko


Re: Review Request 30735: We should be doing disk space check before deploying cluster and/or RU

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30735/#review71467
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Feb. 6, 2015, 12:02 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30735/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 12:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9523
>     https://issues.apache.org/jira/browse/AMBARI-9523
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> It is not a strictly RU issue, but we face it more often when performing RU on a disk-limited instance. So, we should check disk space and warn user if he is likely to have problems.
> We should be doing disk space check on the disk mount for /usr/hdp. Also, it seems like we need to take apt cache into account when calculating available space.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 2c707b2 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 8208ac5 
>   ambari-server/src/test/python/host_scripts/_TestAlertDiskSpace.py PRE-CREATION 
>   ambari-server/src/test/python/unitTests.py e812b83 
> 
> Diff: https://reviews.apache.org/r/30735/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.171s]
> [INFO] Ambari Server ..................................... SUCCESS [28.554s]
> [INFO] Ambari Agent ...................................... SUCCESS [16.160s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 47.456s
> [INFO] Finished at: Fri Feb 06 20:02:19 FET 2015
> [INFO] Final Memory: 48M/417M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>


Re: Review Request 30735: We should be doing disk space check before deploying cluster and/or RU

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30735/#review71461
-----------------------------------------------------------

Ship it!


Nice!

- Alejandro Fernandez


On Feb. 6, 2015, 5:02 p.m., Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30735/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2015, 5:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Tom Beerbower, and Yurii Shylov.
> 
> 
> Bugs: AMBARI-9523
>     https://issues.apache.org/jira/browse/AMBARI-9523
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> It is not a strictly RU issue, but we face it more often when performing RU on a disk-limited instance. So, we should check disk space and warn user if he is likely to have problems.
> We should be doing disk space check on the disk mount for /usr/hdp. Also, it seems like we need to take apt cache into account when calculating available space.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 2c707b2 
>   ambari-server/src/main/resources/host_scripts/alert_disk_space.py 8208ac5 
>   ambari-server/src/test/python/host_scripts/_TestAlertDiskSpace.py PRE-CREATION 
>   ambari-server/src/test/python/unitTests.py e812b83 
> 
> Diff: https://reviews.apache.org/r/30735/diff/
> 
> 
> Testing
> -------
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Ambari Views ...................................... SUCCESS [2.171s]
> [INFO] Ambari Server ..................................... SUCCESS [28.554s]
> [INFO] Ambari Agent ...................................... SUCCESS [16.160s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 47.456s
> [INFO] Finished at: Fri Feb 06 20:02:19 FET 2015
> [INFO] Final Memory: 48M/417M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>