You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Adrien Grand (JIRA)" <ji...@apache.org> on 2016/12/22 19:02:58 UTC
[jira] [Resolved] (LUCENE-7601) Make DocIdMerger.next() unspecified
when exhausted
[ https://issues.apache.org/jira/browse/LUCENE-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adrien Grand resolved LUCENE-7601.
----------------------------------
Resolution: Fixed
Fix Version/s: master (7.0)
I only pushed to master since the problem is on 6.x, since we wrap the docidmerger in a Java Iterator and have asserting classes that make sure hasNext and next behave correctly on an exhausted iterator.
> Make DocIdMerger.next() unspecified when exhausted
> --------------------------------------------------
>
> Key: LUCENE-7601
> URL: https://issues.apache.org/jira/browse/LUCENE-7601
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Priority: Minor
> Fix For: master (7.0)
>
> Attachments: LUCENE-7601.patch
>
>
> Right now there is a comment saying {{NOTE: it's annoying that caller is allowed to call us again even after we returned null before}}, but when I throw an exception in that condition, no tests fail. So maybe we can get rid of this protection now and just make next() unspecified after exhaustion, like {{DocIdSetIterator}}?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org