You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Mark Miller (JIRA)" <ji...@apache.org> on 2009/09/27 06:11:16 UTC

[jira] Created: (SOLR-1465) XPathRecordReader does a bunch of String concat using +

XPathRecordReader does a bunch of String concat using +
-------------------------------------------------------

                 Key: SOLR-1465
                 URL: https://issues.apache.org/jira/browse/SOLR-1465
             Project: Solr
          Issue Type: Bug
          Components: contrib - DataImportHandler
            Reporter: Mark Miller
            Priority: Minor


should use a StringBuilder - very inefficient to keep creating new strings that way

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-1465) XPathRecordReader does a bunch of String concat using +

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar resolved SOLR-1465.
-----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4
         Assignee: Shalin Shekhar Mangar

Committed revision 819892.

Thanks Mark!

> XPathRecordReader does a bunch of String concat using +
> -------------------------------------------------------
>
>                 Key: SOLR-1465
>                 URL: https://issues.apache.org/jira/browse/SOLR-1465
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>            Reporter: Mark Miller
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.4
>
>         Attachments: SOLR-1465.patch
>
>
> should use a StringBuilder - very inefficient to keep creating new strings that way

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1465) XPathRecordReader does a bunch of String concat using +

Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shalin Shekhar Mangar updated SOLR-1465:
----------------------------------------

    Attachment: SOLR-1465.patch

Replaced string concat with StringBuilder appends. All tests pass.

> XPathRecordReader does a bunch of String concat using +
> -------------------------------------------------------
>
>                 Key: SOLR-1465
>                 URL: https://issues.apache.org/jira/browse/SOLR-1465
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>            Reporter: Mark Miller
>            Priority: Minor
>         Attachments: SOLR-1465.patch
>
>
> should use a StringBuilder - very inefficient to keep creating new strings that way

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.