You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/04/06 12:23:05 UTC

[GitHub] [incubator-seatunnel] asdf2014 opened a new pull request, #1667: [Improve] [doc] Using https instead of http for APL2

asdf2014 opened a new pull request, #1667:
URL: https://github.com/apache/incubator-seatunnel/pull/1667

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   This PR is using https instead of http for APL2
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] If any new Jar binary package adding in you PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/development/new-license.md)
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kezhenxu94 closed pull request #1667: [Improve] [doc] Using https instead of http for APL2

Posted by GitBox <gi...@apache.org>.
kezhenxu94 closed pull request #1667: [Improve] [doc] Using https instead of http for APL2
URL: https://github.com/apache/incubator-seatunnel/pull/1667


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] ruanwenjun commented on pull request #1667: [Improve] [doc] Using https instead of http for APL2

Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on PR #1667:
URL: https://github.com/apache/incubator-seatunnel/pull/1667#issuecomment-1090990228

   I find we also use the http link `http://www.apache.org/licenses/LICENSE-2.0.txt` in NOTICE, please replace these links in this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] kezhenxu94 commented on pull request #1667: [Improve] [doc] Using https instead of http for APL2

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on PR #1667:
URL: https://github.com/apache/incubator-seatunnel/pull/1667#issuecomment-1092456622

   @asdf2014 can you please merge all of these 👇 into one PR so that we can review and merge as quickly as possible? In my opinion most (if not all) of these are some chore cleanup or minor refactor, perhaps you can open one single PR with title like "Polish codes" or "clean up"
   
   <img width="1051" alt="image" src="https://user-images.githubusercontent.com/15965696/162370719-a38c374e-50eb-4d11-98c5-fe48eb9d3aea.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] asdf2014 commented on pull request #1667: [Improve] [doc] Using https instead of http for APL2

Posted by GitBox <gi...@apache.org>.
asdf2014 commented on PR #1667:
URL: https://github.com/apache/incubator-seatunnel/pull/1667#issuecomment-1094062054

   @ruanwenjun Nice catch :+1:


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org