[jira] [Commented] (CAMEL-12831) Camel-zipkin: useFallbackServiceNames leaks passwords

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-12831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626178#comment-16626178 ] 

ASF GitHub Bot commented on CAMEL-12831:
----------------------------------------

GitHub user PascalSchumacher opened a pull request:

    https://github.com/apache/camel/pull/2531

    CAMEL-12831: Camel-zipkin: useFallbackServiceNames leaks passwords

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/PascalSchumacher/camel hide_passwords_in_zipkin_fallback_service_names

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/2531.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2531
    
----
commit 74a5e078f41cfff9b3a606ba63d1d07093a75e91
Author: Pascal Schumacher <pa...@...>
Date:   2018-09-24T17:55:00Z

    CAMEL-12831: Camel-zipkin: useFallbackServiceNames leaks passwords

----


> Camel-zipkin: useFallbackServiceNames leaks passwords
> -----------------------------------------------------
>
>                 Key: CAMEL-12831
>                 URL: https://issues.apache.org/jira/browse/CAMEL-12831
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-zipkin
>    Affects Versions: 2.22.1
>            Reporter: Pascal Schumacher
>            Priority: Major
>
> If you do not define service names and useFallbackServiceNames is true (the default setting) camel uses endpoints URIs as services names.
> Passwords in these URIs are not masked and therefore visible in Zipkin traces.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)