[GitHub] [doris] HappenLee commented on a diff in pull request #15597: [Pipeline](load) Support transaction on pipeline engine

[GitBox <gi...@apache.org>]

HappenLee commented on code in PR #15597:
URL: https://github.com/apache/doris/pull/15597#discussion_r1062068588


##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -571,14 +579,24 @@ void FragmentMgr::set_pipe(const TUniqueId& fragment_instance_id,
     }
 }
 
-std::shared_ptr<io::StreamLoadPipe> FragmentMgr::get_pipe(const TUniqueId& fragment_instance_id) {
+std::shared_ptr<io::StreamLoadPipe> FragmentMgr::get_pipe(const TUniqueId& fragment_instance_id,
+                                                          bool enable_pipeline_engine) {
     {
         std::lock_guard<std::mutex> lock(_lock);
-        auto iter = _fragment_map.find(fragment_instance_id);
-        if (iter != _fragment_map.end()) {
-            return _fragment_map[fragment_instance_id]->get_pipe();
+        if (enable_pipeline_engine) {

Review Comment:
   maybe should do double search and remove useless `enable_pipeline_engine` in function param and thrift struct



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org