You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/12/15 08:51:09 UTC

[GitHub] [james-project] Arsnael commented on a diff in pull request #1061: JAMES-3771 Migrate opensearch high level rest client to new java client

Arsnael commented on code in PR #1061:
URL: https://github.com/apache/james-project/pull/1061#discussion_r1049362846


##########
mailbox/opensearch/src/main/java/org/apache/james/mailbox/opensearch/events/OpenSearchListeningMessageSearchIndex.java:
##########
@@ -273,8 +272,11 @@ private ArrayNode extractUserFlags(ObjectNode source) {
     private void extractMessageIdFromHit(Hit<ObjectNode> hit, SynchronousSink<MessageId> sink) {
         JsonData messageId = hit.fields().get(MESSAGE_ID);
         if (messageId != null) {
-            List<String> extractMessageId = messageId.deserialize(JsonpDeserializer.arrayDeserializer(JsonpDeserializer.stringDeserializer()));
-            sink.next(messageIdFactory.fromString(extractMessageId.get(0)));

Review Comment:
   jstack and flame graphs during perf tests, where you could see there was an issue around there in the stack traces



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org