You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "alexjinghn (via GitHub)" <gi...@apache.org> on 2023/04/13 22:04:01 UTC

[GitHub] [spark] alexjinghn commented on pull request #40747: [SPARK-43099][SQL] Use `getName` instead of `getCanonicalName` to get builder class name when registering udf to FunctionRegistry

alexjinghn commented on PR #40747:
URL: https://github.com/apache/spark/pull/40747#issuecomment-1507662454

   @yaooqinn @LuciferYang Thanks for the suggestion. I've added a test and verified that the test captures the failure (fails w/o my change, passes w/ my change).
   
   @HyukjinKwon this should be able to be reproduced as long as it runs on JDK15+ since the root cause is the classloader API behavior change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org