You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2012/07/31 00:50:55 UTC
Review Request: Add os::nonblock utility functions to set/check NONBLOCK
flag for file descriptors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6217/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, John Sirois, and Vinod Kone.
Description
-------
Add utility functions to set/check NONBLOCK flag for opened file descriptors.
Diffs
-----
src/tests/stout_tests.cpp f601d64
third_party/libprocess/include/stout/os.hpp 1186d24
Diff: https://reviews.apache.org/r/6217/diff/
Testing
-------
make check.
Thanks,
Jie Yu
Re: Review Request: Add os::nonblock utility functions to set/check NONBLOCK
flag for file descriptors.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6217/#review9614
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On July 30, 2012, 10:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6217/
> -----------------------------------------------------------
>
> (Updated July 30, 2012, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, John Sirois, and Vinod Kone.
>
>
> Description
> -------
>
> Add utility functions to set/check NONBLOCK flag for opened file descriptors.
>
>
> Diffs
> -----
>
> src/tests/stout_tests.cpp f601d64
> third_party/libprocess/include/stout/os.hpp 1186d24
>
> Diff: https://reviews.apache.org/r/6217/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request: Add os::nonblock utility functions to set/check NONBLOCK
flag for file descriptors.
Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6217/#review9651
-----------------------------------------------------------
Ship it!
third_party/libprocess/include/stout/os.hpp
<https://reviews.apache.org/r/6217/#comment20567>
ideas for a better name - Ben will have an opinion here I think:
makeNonblocking setNonblocking nonblocking
- John Sirois
On July 30, 2012, 10:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6217/
> -----------------------------------------------------------
>
> (Updated July 30, 2012, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, John Sirois, and Vinod Kone.
>
>
> Description
> -------
>
> Add utility functions to set/check NONBLOCK flag for opened file descriptors.
>
>
> Diffs
> -----
>
> src/tests/stout_tests.cpp f601d64
> third_party/libprocess/include/stout/os.hpp 1186d24
>
> Diff: https://reviews.apache.org/r/6217/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jie Yu
>
>