You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Daniel Gornstein <dg...@mitre.org> on 2013/06/25 19:34:59 UTC

Review Request 12081: Moving event bindings into JSP files

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12081/
-----------------------------------------------------------

Review request for rave.


Repository: rave


Description
-------

Moving event bindings into JSP files


Diffs
-----

  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.jsp 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.marketplace.jsp 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgetdetail.jsp 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/mobile_home.jsp 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.marketplace.jsp 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_opensocial.js 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/main.js 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_event_bindings.js 1496437 
  /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_models.js 1496437 

Diff: https://reviews.apache.org/r/12081/diff/


Testing
-------


Thanks,

Daniel Gornstein

Re: Review Request 12081: Moving event bindings into JSP files

Posted by Erin Noe-Payne <er...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12081/#review22361
-----------------------------------------------------------

Ship it!


This patch is dropping the rave_event_bindings file and moving the event bindings onto the jsp's. These are all event bindings that were originally located inline in the html as onclick, etc events. These aren't shared actions and they aren't.

Embedding in jsp's is not ideal but it's an improvement over inline and was needed to support requirejs.

- Erin Noe-Payne


On June 25, 2013, 5:34 p.m., Daniel Gornstein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12081/
> -----------------------------------------------------------
> 
> (Updated June 25, 2013, 5:34 p.m.)
> 
> 
> Review request for rave.
> 
> 
> Repository: rave
> 
> 
> Description
> -------
> 
> Moving event bindings into JSP files
> 
> 
> Diffs
> -----
> 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.jsp 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/addwidget.marketplace.jsp 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/widgetdetail.jsp 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/mobile_home.jsp 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/page.jsp 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/store.jsp 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.jsp 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/widget.marketplace.jsp 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/core/rave_opensocial.js 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/main.js 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_event_bindings.js 1496437 
>   /branches/require/rave-portal-resources/src/main/webapp/static/script/portal/rave_models.js 1496437 
> 
> Diff: https://reviews.apache.org/r/12081/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Gornstein
> 
>