[jira] [Created] (NET-544) initiateListParsing does not correctly check if parserKey was cached

["Olivier Queyrut (JIRA)" <ji...@apache.org>]

Olivier Queyrut created NET-544:
-----------------------------------

             Summary: initiateListParsing does not correctly check if parserKey was cached
                 Key: NET-544
                 URL: https://issues.apache.org/jira/browse/NET-544
             Project: Commons Net
          Issue Type: Bug
          Components: FTP
    Affects Versions: 3.3
            Reporter: Olivier Queyrut
            Priority: Minor


At line 3232 of FTPClient, it is mentionned that the parserKey and entryParser are cached "to avoid creation of a new object every time a file listing is generated".

However the test seems to be incorrect as a new entryParser is created every time the method "listFiles" is called. Indeed, in method named listFiles, the initiateListParsing is called with a null argument for the parserKey.
So the test : "if(__entryParser == null ||  ! __entryParserKey.equals(parserKey))" is always true (even if __entryParserKey has been cached) and thus a new entryParser is created.



--
This message was sent by Atlassian JIRA
(v6.2#6252)