You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2019/09/05 14:54:45 UTC

[impala] 02/03: IMPALA-8915: reapply IMPALA-8901 fix

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 53aa0add886bde95b53597a01501844dbec3a93c
Author: Tim Armstrong <ta...@cloudera.com>
AuthorDate: Tue Sep 3 22:23:31 2019 -0700

    IMPALA-8915: reapply IMPALA-8901 fix
    
    This reapplies the below fix and resolves conflicts correctly.
    
    IMPALA-8901: Fix # links on /catalog page.
    
    After IMPALA-7935, the database links on the top of /catalog page
    that use # links to jump to the part of the page corresponding to
    the particular database is broken because the id is ommitted. This is
    fixed by moving id to a tag which doesn't change if local catalog is
    turned on.
    
    Testing:
    Manually tested the links are working in both local catalog mode and
    V1 mode.
    
    Change-Id: I42ea1ec4c386f2eb45f370cd35a104b49786a48c
    Reviewed-on: http://gerrit.cloudera.org:8080/14176
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 www/catalog.tmpl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/catalog.tmpl b/www/catalog.tmpl
index 862594e..126c658 100644
--- a/www/catalog.tmpl
+++ b/www/catalog.tmpl
@@ -168,7 +168,7 @@ under the License.
   {{^use_local_catalog}}
     <a href='{{ __common__.host-url }}/catalog_object?object_type=DATABASE&object_name={{name}}'>
   {{/use_local_catalog}}
-      <h5 class="card-title">{{name}}
+      <h5 class="card-title" id='{{name}}'>{{name}}
       <span class="float-right">{{num_tables}} table(s)</span></h5>
   {{^use_local_catalog}}
     </a>