You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Josh Elser (Jira)" <ji...@apache.org> on 2021/11/18 01:17:00 UTC

[jira] [Resolved] (HBASE-26453) [hboss] removeInMemoryLocks can remove still in-use locks

     [ https://issues.apache.org/jira/browse/HBASE-26453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Elser resolved HBASE-26453.
--------------------------------
    Fix Version/s: hbase-filesystem-1.0.0-alpha2
     Hadoop Flags: Reviewed
       Resolution: Fixed

> [hboss] removeInMemoryLocks can remove still in-use locks
> ---------------------------------------------------------
>
>                 Key: HBASE-26453
>                 URL: https://issues.apache.org/jira/browse/HBASE-26453
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: hbase-filesystem-1.0.0-alpha1
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: hbase-filesystem-1.0.0-alpha2
>
>
> While implementing HBASE-26437, I was fighting with unit tests which just wouldn't complete. After adding the code change to delete the locks held by the {{src}} in a {{mv src dst}} operation, releasing the {{dst}} lock would claim that the current thread doesn't hold the lock.
> After investigating, the specific contract test in question is doing a rename of the form: {{{}mv /foo /foodest{}}}. This actually breaks the logic which tries to determine if a lock's path is contained beneath the path we're tryign to clean up. Specifically: cleaning up locks beneath {{/foo}} incorrectly removes locks for {{/foodest}}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)