You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/10/02 20:17:24 UTC
Review Request 26274: Remove /proc and /sys remounts from port_mapping
isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26274/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-1853
https://issues.apache.org/jira/browse/MESOS-1853
Repository: mesos-git
Description
-------
Remove /proc and /sys remounts from port_mapping isolator. See ticket for details.
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 2766a00ff81dc550c21387f920666f81705db4f0
Diff: https://reviews.apache.org/r/26274/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 26274: Remove /proc and /sys remounts from
port_mapping isolator.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26274/#review56215
-----------------------------------------------------------
Ship it!
Please make sure to test it before committing this.
- Jie Yu
On Oct. 10, 2014, 8:48 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26274/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2014, 8:48 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1853
> https://issues.apache.org/jira/browse/MESOS-1853
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove /proc and /sys remounts from port_mapping isolator. See ticket for details.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 8ddfb1817d78c45ce2f6daebbeb13d380998ee4d
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
>
> Diff: https://reviews.apache.org/r/26274/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 26274: Remove /proc and /sys remounts from
port_mapping isolator.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26274/#review56580
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26274]
All tests passed.
- Mesos ReviewBot
On Oct. 14, 2014, 8:33 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26274/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 8:33 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1853
> https://issues.apache.org/jira/browse/MESOS-1853
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove /proc and /sys remounts from port_mapping isolator. See ticket for details.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 62ca9bca08de55f19bfff7b8828dfa4fb6c51f30
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
>
> Diff: https://reviews.apache.org/r/26274/diff/
>
>
> Testing
> -------
>
> make check # Linux after `configure --with-network-isolator`
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 26274: Remove /proc and /sys remounts from
port_mapping isolator.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26274/
-----------------------------------------------------------
(Updated Oct. 14, 2014, 1:33 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-1853
https://issues.apache.org/jira/browse/MESOS-1853
Repository: mesos-git
Description
-------
Remove /proc and /sys remounts from port_mapping isolator. See ticket for details.
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 62ca9bca08de55f19bfff7b8828dfa4fb6c51f30
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
Diff: https://reviews.apache.org/r/26274/diff/
Testing (updated)
-------
make check # Linux after `configure --with-network-isolator`
Thanks,
Ian Downes
Re: Review Request 26274: Remove /proc and /sys remounts from
port_mapping isolator.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26274/#review56236
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26274]
All tests passed.
- Mesos ReviewBot
On Oct. 10, 2014, 8:48 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26274/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2014, 8:48 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1853
> https://issues.apache.org/jira/browse/MESOS-1853
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove /proc and /sys remounts from port_mapping isolator. See ticket for details.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 8ddfb1817d78c45ce2f6daebbeb13d380998ee4d
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
>
> Diff: https://reviews.apache.org/r/26274/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 26274: Remove /proc and /sys remounts from
port_mapping isolator.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26274/
-----------------------------------------------------------
(Updated Oct. 10, 2014, 1:48 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Changes
-------
Corrected a comment.
Bugs: MESOS-1853
https://issues.apache.org/jira/browse/MESOS-1853
Repository: mesos-git
Description
-------
Remove /proc and /sys remounts from port_mapping isolator. See ticket for details.
Diffs (updated)
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 8ddfb1817d78c45ce2f6daebbeb13d380998ee4d
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
Diff: https://reviews.apache.org/r/26274/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 26274: Remove /proc and /sys remounts from
port_mapping isolator.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26274/#review55245
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26274]
All tests passed.
- Mesos ReviewBot
On Oct. 2, 2014, 6:17 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26274/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 6:17 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-1853
> https://issues.apache.org/jira/browse/MESOS-1853
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Remove /proc and /sys remounts from port_mapping isolator. See ticket for details.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 2766a00ff81dc550c21387f920666f81705db4f0
>
> Diff: https://reviews.apache.org/r/26274/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>